Fixed a bug related to sensible/latent heat fluxes for AQM coupling (Issue#945)#951
Fixed a bug related to sensible/latent heat fluxes for AQM coupling (Issue#945)#951ChunxiZhang-NOAA wants to merge 1 commit into
Conversation
…n GFS_PBL_generic_post.F90
ChunxiZhang-NOAA
requested review from
SamuelTrahanNOAA,
climbfuji,
grantfirl,
mkavulich,
mzhangw and
panll
as code owners
|
Does anyone know if @rmontuoro (the original author of this section) agrees with the solution? |
grantfirl
left a comment
grantfirl
left a comment
There was a problem hiding this comment.
I'm assuming that the bug is a result of copy/paste for the case when cplflx = T above? Regardless, the fix should work to fix the reported issue.
|
@grantfirl Maybe we should invite Raffaele to review this code change. |
|
@ChunxiZhang-NOAA, @grantfirl - Thanks. I will take a look and get back to you. |
|
The proposed changes do not address the lack of surface net heat fluxes over land, which need to be provided to AQM. A new formulation is proposed in PR #953. |
|
@ChunxiZhang-NOAA @rmontuoro Should we close this (and upstream PRs) in favor of merging #953 (and upstream PRs)? |
|
@grantfirl We can close this PR. |
|
Closing this PR in favor of continuing discussion of the solution in #953 |
4 participants
A bug is fixed which is described in Issue#945.
Currently, this PR only fixed the bug that caused model crashes due to the unallocated variables dtsfc_cice and dqsfc_cice which are only allocated when cplflx=.true. in GFS_typedefs.F90.
There are potential other issues. For instance, when (cplaqm .and. .not.cplflx) is ture, dtsfci_cpl and dqsfci_cpl are only assigned values over ocean (e.g., oceanfrac > 0).