AQM updates#1383
Closed
rmontuoro wants to merge 7 commits into
Closed
Conversation
16 tasks
Collaborator
|
What we prefer for making changes to authoritative repos (in this case AQM), is for PR's to be made from personal forks of authoritative repos and not branches created in authoritative repos. Please keep this in mind for future PR's. We can use your AQM branch bugfix/restore-epa-cmaq this time. Also in .gitmodules we like to have the AQM section point to the repo/branch you're working on. Please make that change to .gitmodules, as we will revert it prior to merging at the end. |
Collaborator
|
I was able to test this on Orion and everything passed except atmaq, which is what was expected. |
16 tasks
16 tasks
jkbk2004
pushed a commit
that referenced
this pull request
Sep 9, 2022
* acorn and common .lua changes, hera.intel (not hera.gnu) .lua changes * CMake_Platform --> CMAKE_Platform * jet and wcoss2 .lua changes, cheyenne.gnu/intel lua updates, orion lua updates, typo in jet.lua files, Orion fixes for .lua files * Set proper number of non-advected tracers in regional_atmaq regression test. * Add proper convective scavenging coefficients to the regional_ataqm regression test. * Update ufs_s4.intel.lua, Update ufs_s4.intel_debug.lua
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
This PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR. Please consult the ufs-weather-model wiki if you are unsure how to do this.
This PR has been tested using a branch which is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR
An Issue describing the work contained in this PR has been created either in the subcomponent(s) or in the ufs-weather-model. The Issue should be created in the repository that is most relevant to the changes in contained in the PR. The Issue and the dependent sub-component PR
are specified below.
Results for one or more of the regression tests change and the reasons for the changes are understood and explained below.
New or updated input data is required by this PR. If checked, please work with the code managers to update input data sets on all platforms.
Description
This PR introduces the following updates relevant to the coupled UFS-AQM configuration (Online-CMAQ):
regional_atmaqregression testThese updates will change the baseline for
regional_atmaq.Issue(s) addressed
Testing
Dependencies