Skip to content

moninshoc.meta missing mfpbl.f dependency#1254

Closed
SamuelTrahanNOAA wants to merge 2 commits into
ufs-community:developfrom
SamuelTrahanNOAA:bugfix/sam-broke-moorthi
Closed

moninshoc.meta missing mfpbl.f dependency#1254
SamuelTrahanNOAA wants to merge 2 commits into
ufs-community:developfrom
SamuelTrahanNOAA:bugfix/sam-broke-moorthi

Conversation

@SamuelTrahanNOAA
Copy link
Copy Markdown
Collaborator

PR Checklist

  • This PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR. Please consult the ufs-weather-model wiki if you are unsure how to do this.

  • This PR has been tested using a branch which is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR

  • An Issue describing the work contained in this PR has been created either in the subcomponent(s) or in the ufs-weather-model. The Issue should be created in the repository that is most relevant to the changes in contained in the PR. The Issue and the dependent sub-component PR are specified below.

  • Results for one or more of the regression tests change and the reasons for the changes are understood and explained below.

  • New or updated input data is required by this PR. If checked, please work with the code managers to update input data sets on all platforms.

Instructions: All subsequent sections of text should be filled in as appropriate.

The information provided below allows the code managers to understand the changes relevant to this PR, whether those changes are in the ufs-weather-model repository or in a subcomponent repository. Ufs-weather-model code managers will use the information provided to add any applicable labels, assign reviewers and place it in the Commit Queue. Once the PR is in the Commit Queue, it is the PR owner's responsibility to keep the PR up-to-date with the develop branch of ufs-weather-model.

Description

A recent addition of "module" statements at the top of some files broke moninshoc. This adds a dependency so moninshoc will compile. There are three changes:

  1. moninshoc.meta has the necessary dependency
  2. rt.conf will compile the FV3_GFS_cpld_rasmgshocnsstnoahmp_ugwp suite to ensure moninshoc builds
  3. rt_gnu.conf will compile the FV3_GFS_cpld_rasmgshocnsstnoahmp_ugwp suite to ensure moninshoc builds

Issue(s) addressed

NCAR/ccpp-physics#935

Testing

How were these changes tested? What compilers / HPCs was it tested with? Are the changes covered by regression tests? (If not, why? Do new tests need to be added?) Have regression tests and unit tests (utests) been run? On which platforms and with which compilers? (Note that unit tests can only be run on tier-1 platforms)

  • hera.intel
  • hera.gnu
  • orion.intel
  • cheyenne.intel
  • cheyenne.gnu
  • gaea.intel
  • jet.intel
  • wcoss2.intel
  • wcoss_cray
  • wcoss_dell_p3
  • opnReqTest for newly added/changed feature
  • CI

Dependencies

ccpp-physics: NCAR/ccpp-physics#934
fv3atm: NOAA-EMC/ufsatm#545

@SamuelTrahanNOAA
Copy link
Copy Markdown
Collaborator Author

This has been merged into #1257

@junwang-noaa
Copy link
Copy Markdown
Collaborator

Merged through PR#1257.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

No Baseline Change No Baseline Change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants