Remove extra logic that reduces optimization for radiation_aerosols.f, update CODEOWNERS#771
Closed
climbfuji wants to merge 2 commits into
Closed
Remove extra logic that reduces optimization for radiation_aerosols.f, update CODEOWNERS#771climbfuji wants to merge 2 commits into
climbfuji wants to merge 2 commits into
Conversation
… from AVX2 to AVX-I
climbfuji
changed the title
Collaborator
Author
|
This PR was pulled into #773 and merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove extra logic that reduces optimization for
radiation_aerosols.ffrom AVX2 to AVX-I.In the distant past, this was required to maintain run-to-run reproducibility with an old version of the Intel compiler (v15?) on one of the WCOSS systems (I think). Tests on Hera with Intel 18 show that the code runs fine when using AVX2 for
radiation_aerosols.fThis change changes the baseline of all model runs.
Also: add @mzhangw and @panll to CODEOWNERS file.