Bugfix for extra top layer GFS_rrtmg_pre setup#635
Merged
Conversation
pulling latest master into local ltp-bugfix
…ure, temperature, and specific humidity for Thompson MP. Use extended arrays plyr, tlyr, and qlyr respectively.
matusmartini
requested review from
JulieSchramm,
climbfuji,
grantfirl and
llpcarson
as code owners
climbfuji
approved these changes
Apr 20, 2021
Collaborator
climbfuji
left a comment
climbfuji
left a comment
There was a problem hiding this comment.
This looks good to me, thanks very much for submitting this bugfix. I will look for a spot in the commit queue for your changes.
JohanaRomeroAlvarez
pushed a commit
to JohanaRomeroAlvarez/ccpp-physics
that referenced
this pull request
Sep 8, 2025
* MYNN update * "merge RRFS-SD from the GSL repo to the Community repo" * "include MYNN-EDMF updates from PR #630" Co-authored-by: joeolson42 <Joseph.B.Olson@noaa.gov> Co-authored-by: Haiqin.Li <Haiqin.Li@noaa.gov>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request resolves #632
Includes fixes of array-out-of-bounds errors when extra top layer is used for pressure, temperature, and specific humidity for Thompson MP. Instead of prsl, tgrs, and qgrs extended arrays plyr, tlyr, and qlyr respectively are used which are defined in the extra top radiation layer.
Includes comment correction for pressure units for plyr, and removes white space.