Update error messaging in sfcsub.F to conform to NCEP/NCO standards#628
Update error messaging in sfcsub.F to conform to NCEP/NCO standards#628GeorgeGayno-NOAA wants to merge 3 commits into
Conversation
standards. Fixes #625
GeorgeGayno-NOAA
requested review from
JulieSchramm,
climbfuji,
grantfirl and
llpcarson
as code owners
|
What official testing is required before merging? |
A ton. We have to add this to the ufs-weather-model commit queue (with corresponding PRs in fv3atm and ufs-weather-model to handle the submodule pointer updates), run regression tests on all tier-1 platforms and CI tests. You don't need to worry, since your PR is so small I will combine it with other changes and handle the submodule pointer updates. Note however that the CCPP rules do not allow writing to stdout/stderr directly. Instead, an error message needs to be populated with the corresponding information, an error flag set to 1 and the code needs to return. The CCPP framework then escalated this to the host model, which writes out the error message and aborts. Making this change is beyond the purpose of this PR, but it is important that we work towards this capability in he future. It needs to work with UFS_UTILS and at the same time be in compliance with NCO error reporting standards. |
|
This update has been absorbed by PR #641. Closing. |
* add IFI to post * pass w to model & fixes to ccpp/physics changes * send lightning threat indexes to post * upp: remove 444 ltng and add 704 * ccpp/physics: fill ltg*_max with 0 when model is hydrostatic * atmos_cubed_sphere: only send w to model in non-hydrostatic mode, and only if model wants it * disable lightning_threat when hydrostatic, and initialize wgrs * turn off lightning_threat by default since it allocates wgrs and passes w * missing `active = (lightning_threat_indices_enabled)` for wgrd * UPP submodule: correct ifi load on acorn * remove unneeded initialization of ltg*_max in post_fv3 * remove unneeded hydrostatic check from maximum_hourly_diagnostics * fix out-of-bounds access in upp calslr_roebbr * fix another out-of-bounds access and move a message to stdout
2 participants
Error messages updated. Function of code was not changed.
Fixes #625