ugwpv1_gsldrag bug fixes, and GFS_typdefs updates associated with diag flags for ugwpv1_gsldrag.F90 and GFS_DCNV_generic.F90#634
Merged
Conversation
…g flags for ugwpv1_gsldrag and GFS_DCNV_generic.F90
mdtoy
requested review from
JulieSchramm,
climbfuji,
grantfirl and
llpcarson
as code owners
climbfuji
requested review from
matusmartini
and removed request for
matusmartini
JohanaRomeroAlvarez
pushed a commit
to JohanaRomeroAlvarez/ccpp-physics
that referenced
this pull request
Sep 8, 2025
…/framework submodule pointer update for NCAR#462 (NCAR#634) * add nssl_alphar, nssl_ehw0_in, nssl_ehlw0_in to namelist entries for ensemble perturbationsons * update the standard name for hail/graupel collection efficiency * update the long names for parameters related to NSSL microphysics * update ccpp/physics and ccpp/framework submodule pointers --------- Co-authored-by: Jili Dong <Jili.Dong@noaa.gov>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a bug in the final accumulation of tendencies at the end of subroutine ugwpv1_gsldrag_run in module ugwpv1_gsldrag.
Fixes inconsistencies between allocation of diagnostic variables in GFS_typedefs.F90 and ugwpv1_gsldrag.F90 as determined by logical flags.
Fixes inconsistencies between allocation of diagnostic variables in GFS_typedefs.F90 and GFS_DCNV_generic.F90 as determined by logical flags.