Move sfc emis alb calculation to its own scheme and z0 composite consistent by climbfuji · Pull Request #627 · NCAR/ccpp-physics

climbfuji · 2021-04-15T22:27:04Z

Description

Initialize surface albedo and surface emissivity in GFS_phys_time_vary_init for both NoahMP and RUC LSM (previously only for NoahMP)
Update surface albedo and surface emissivity calculation. Move calls to these radiation-scheme independent codes to its own CCPP scheme. From @tanyasmirnova with modifications from @climbfuji.
Consistent calculation of surface fluxes and surface roughness length in GFS_surface_composites. For now, the stability routine from GFS's sfc_diff code is used in GFS_surface_composites_post, independent of which surface layer scheme gets used. From @benwgreen with modifications from @climbfuji.
Bugfixes to several schemes (RRTMGP, MYNSFC, RUCLSM) to use the correct horizontal dimension in the CCPP metadata files.

Note. During development and testing, we added an option ORIG_ALB_EMS_OPTION_ONE to radiation_surface.f. This CPP directive can be enabled and should allow us to get identical answers for most of the regression tests compared tto the existing baseline. This provides us with a more controlled way to understand the differences in the regression tests.
The old code block and ORIG_ALB_EMS_OPTION_ONE logic will be removed prior to the final regression testing and merging of the code. More information will be given in ufs-community/ufs-weather-model#529. UPDATE This code has been removed.

Testing

See ufs-community/ufs-weather-model#529

Dependencies

#627
NCAR/ccpp-framework#366
NOAA-EMC/ufsatm#285
ufs-community/ufs-weather-model#529

radiation.

…ter_20210331 Update gsl/develop from master 2021/03/31

GFS_phys_time_vary_init.

…into frac_emiss_albedo

frac_grid=.false.

…ccpp-physics into HEAD

…emes into GFS_radiation_surface, consolidate, fix bugs

lsm_ruc_init. This is needed for MYNN surface layer scheme at the first time step.

…composites_post, add necessary new interstitial variables, clean up old/unused interstitial variables

…ve_sfc_emis_alb_calculation_to_its_own_scheme_and_z0_composite_consistent

…om OpenMP

benwgreen · 2021-04-19T16:40:56Z

+! BWG, 2021/02/25: cmm=cd*wind, chh=cdq*wind, so use composite cd, cdq
+          q0       = max( q1(i), qmin )
+          rho      = prsl1(i) / (rd*t1(i)*(one + rvrdm1*q0))
+          cmm(i)    =      cd(i)*wind(i)  !txl*cmm_lnd(i)    + txi*cmm_ice(i)    + txo*cmm_wat(i)


The cmm and chh here were supposed to be based off the composite values of cd and cdq from the "fourth call" to the stability subroutine -- so shouldn't Lines 444-445 go further down?

Good point!

benwgreen · 2021-04-19T16:42:21Z

+! BWG, 2021/02/25: Need to change composite skin temperature base on ULW (Fanglin)
+          !tsfc(i)   = txl*tsfc_lnd(i)   + txi*tice(i)       + txo*tsfc_wat(i)
+          tsfc(i)   = ( txl * cdq_lnd(i) * tsfc_lnd(i)                          &
+                      + txi * cdq_ice(i) * tice(i)                              & ! DH* Ben had tsurf_ice(i), but GFS_surface_composites_post_run uses tice instead


We may need to double-check with Moorthi. I'm not tagging him yet though.

These different ice temperatures are a real mess. II will try to read through the code to see what the difference is.

benwgreen · 2021-04-19T16:44:19Z

+!         layer parameterization being used - to be extended in the future            !
+!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
+
+! BWG, 2021/02/25: Need to change composite skin temperature base on ULW (Fanglin)


Upon further thought, this comment may now be misleading. Fanglin had multiple ideas on how to composite surface temperature (besides simple arithmetic mean). For the instance of "stability", we are going with Mike Barlage's method. We should double-check with him to see if he wants this composite method to be used everywhere, or just for sfc_diff.

Let me know if I should remove the comment, please.

Might as well.

benwgreen · 2021-04-19T16:46:55Z

+                      + txo * cdq_wat(i) * tsurf_wat(i))                        &
+                      / (txl * cdq_lnd(i) + txi * cdq_ice(i) + txo * cdq_wat(i) )
+
+          virtfac = one + rvrdm1 * max(q1(i),qmin)


Could this line be moved up to go right around Line 442? That would consolidate code (we can use "q0 = max(q1(i),qmin)" ).

…fter call to stability

benwgreen · 2021-04-19T18:07:04Z

                         stress(i), uustar(i))

+          ! BWG, 2021/02/25: cmm=cd*wind, chh=cdq*wind, so use composite cd, cdq
+          q0       = max( q1(i), qmin )


With this new change (moving down these lines) I think you can move the q0 line to go right before Line 478 which allows 478 to be virtfac = one + rvrdm1 * q0
Then, Line 498 can be rho = prsl1(i) / (rd * t1 * virtfac) ... right?

That is what I did

Sorry, for some reason it was showing up incorrectly. Once I refreshed again I see that you consolidated as suggested.

climbfuji · 2021-05-20T19:40:58Z

I echoed what fanglin said. Maybe there are some issues for the solar zenith angel dependence calculation over ocean.
For my tests, I use the main CCPP-physics branch (HEAD detached at 1fd62ea) as a control, and move_sfc_emis_alb_calculation_to_its_own_scheme_and_z0_composite_consistent (HEAD detached at 38f28a2) for the test case. I didn't use fractional grid for both runs.

@climbfuji Dom, could you please confirm that the suite definitions in the code used by Helin is correct?

@HelinWei-NOAA please post you suite definition file or share a link to the file on hera (or any other RDHPC platform), please. Thanks!

HelinWei-NOAA · 2021-05-20T20:00:07Z

I ran my cases on wcoss. But I just copied suite_FV3_GFS_v16_noahmp.xml I used for this run to Hera:/scratch1/NCEPDEV/stmp2/Helin.Wei

…

On Thu, May 20, 2021 at 3:41 PM Dom Heinzeller ***@***.***> wrote: I echoed what fanglin said. Maybe there are some issues for the solar zenith angel dependence calculation over ocean. For my tests, I use the main CCPP-physics branch (HEAD detached at 1fd62ea <1fd62ea>) as a control, and move_sfc_emis_alb_calculation_to_its_own_scheme_and_z0_composite_consistent (HEAD detached at 38f28a2 <38f28a2>) for the test case. I didn't use fractional grid for both runs. @climbfuji <https://github.com/climbfuji> Dom, could you please confirm that the suite definitions in the code used by Helin is correct? @HelinWei-NOAA <https://github.com/HelinWei-NOAA> please post you suite definition file or share a link to the file on hera (or any other RDHPC platform), please. Thanks! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#627 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ALPHKYEUJTYUV6HBUSSQOGDTOVQV5ANCNFSM43ALMRSQ> .

tanyasmirnova · 2021-05-20T20:35:48Z

@HelinWei-NOAA @climbfuji The suite definition looks good to me. Thank you!

albedo.

…on_to_its_own_scheme_and_z0_composite_consistent_tgs Removed SNET.

…d GFS_interstitialtoscreen

…_sfc_emis_alb_calculation_to_its_own_scheme_and_z0_composite_consistent

…t, _timestep_init, _timestep_final, _final routines; use horizontal_loop_extent in _run routines

climbfuji · 2021-05-26T22:26:49Z

@grantfirl @tanyasmirnova @benwgreen @SMoorthi-emc @HelinWei-NOAA @JulieSchramm @llpcarson @barlage @yangfanglin @shansun6 @dustinswales Finally this PR is ready to commit. Please have a(nother) look if you can/want, since the changes are substantial. Thanks a lot.

tanyasmirnova

@climbfuji Thank you very much for your tremendous work on this very complicated PR.

benwgreen · 2021-05-27T01:25:29Z

@climbfuji Thank you very much for your tremendous work on this very complicated PR.

For some reason I'm not a formal reviewer, but I am okay with the code. I owe you (@climbfuji) a beer or 5 for all of the hard work you did -- much appreciated!

climbfuji · 2021-05-27T01:55:34Z

@climbfuji Thank you very much for your tremendous work on this very complicated PR.

For some reason I'm not a formal reviewer, but I am okay with the code. I owe you (@climbfuji) a beer or 5 for all of the hard work you did -- much appreciated!

Actually, you are listed as a reviewer, just need to go to the 'files changed' tab and then you should see the review button. I'd love to have a beer or five with everyone involved in this PR!

ShanSunNOAA

Thanks for the hard work!

HelinWei-NOAA · 2021-05-27T02:27:37Z

@climbfuji for this commit "Removed SNET. Net sloar radiation is computed from the incoming SW and albedo", only sfc_drv_ruc.F90 was modified for RUC LSM. sfc_drv.f should also be modified for Noah LSM.

climbfuji · 2021-05-27T03:28:38Z

Ok, thanks. This should be a follow-up PR then.

…

On May 26, 2021, at 8:27 PM, HelinWei-NOAA ***@***.***> wrote: @climbfuji <https://github.com/climbfuji> for this commit "Removed SNET. Net sloar radiation is computed from the incoming SW and albedo", only sfc_drv_ruc.F90 was modified for RUC LSM. sfc_drv.f should also be modified for Noah LSM. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#627 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AB5C2RNWXCWFEAATIJBX2A3TPWU2LANCNFSM43ALMRSQ>.

dustinswales

All of the changes to the GP code look fine to me.
Great work!

…nout' (NCAR#627) * Changed UGWP diagnostic variable declaration intents from 'out' to 'inout' * Updated UGWP diagnostic variable declaration intents in drag_suite.meta

tanyasmirnova and others added 13 commits March 26, 2021 19:45

Consistent use of emissivity and albedo between RUC LSM and the

756f2cf

radiation.

Merged Moorthi's changes for fractional grid in setemis.

67ddbbd

Step forward towards fractional albedo and emissivity in the LSM option.

25611d7

Merge pull request NCAR#83 from climbfuji/update_gsl_develop_from_mas…

25f789f

…ter_20210331 Update gsl/develop from master 2021/03/31

Fix CODEOWNERS

21df401

Added initialization of 4 albedo components over land and ice to

ed7db4d

GFS_phys_time_vary_init.

Change intent from out to inout for albedo.

ad1ad67

Fixed problems with the initialization of albedo and emissivity.

ea0c6f0

Merge branch 'gsl/develop' of https://github.com/NOAA-GSL/ccpp-physics …

b7cbcce

…into frac_emiss_albedo

Added the code to compute land, water and ice fractions when

d4531cd

frac_grid=.false.

Adding composite changes on top of Tanya's changes

e140651

Merge branch 'bwg_frac_emiss_albedo' of https://github.com/benwgreen/…

efcc07c

…ccpp-physics into HEAD

Move calculation of surface albedo/emissivity out of rrtmg(p) pre sch…

e871573

…emes into GFS_radiation_surface, consolidate, fix bugs

tanyasmirnova and others added 6 commits April 16, 2021 18:49

Add initialization of water vapor mixing ratio at the surface to

c4e0873

lsm_ruc_init. This is needed for MYNN surface layer scheme at the first time step.

Bug fix in the composite for ialb=2 option.

cbbafc5

Move call to 'stability' for composites from sfc_diff to GFS_surface_…

8367123

…composites_post, add necessary new interstitial variables, clean up old/unused interstitial variables

Merge branch 'master' of https://github.com/NCAR/ccpp-physics into mo…

823f6ed

…ve_sfc_emis_alb_calculation_to_its_own_scheme_and_z0_composite_consistent

Fix merge conflicts

ff766e5

Bugfix in physics/GFS_phys_time_vary.fv3.F90: remove old variables fr…

1a2d365

…om OpenMP

benwgreen reviewed Apr 19, 2021

View reviewed changes

physics/GFS_surface_composites.F90: move computation of cmm and chh a…

a6ade33

…fter call to stability

benwgreen reviewed Apr 19, 2021

View reviewed changes

tanyasmirnova and others added 2 commits April 19, 2021 18:19

Add fractional code to ialb=1 option used with the Noah LSM.

d83c1a1

Address reviewer comments

21c87c4

tanyasmirnova and others added 5 commits May 25, 2021 13:41

Removed SNET. Net sloar radiation is computed from the incoming SW and

c3375bb

albedo.

Merge pull request #15 from tanyasmirnova/move_sfc_emis_alb_calculati…

01bb2d5

…on_to_its_own_scheme_and_z0_composite_consistent_tgs Removed SNET.

Add timestep_init andd timestep_final versions of GFS_diagtoscreen an…

0a8aa3a

…d GFS_interstitialtoscreen

Merge branch 'main' of https://github.com/NCAR/ccpp-physics into move…

a6df017

…_sfc_emis_alb_calculation_to_its_own_scheme_and_z0_composite_consistent

Bug fixes in several metadata files: use horizontal_dimension in _ini…

0350697

…t, _timestep_init, _timestep_final, _final routines; use horizontal_loop_extent in _run routines

tanyasmirnova approved these changes May 26, 2021

View reviewed changes

ShanSunNOAA approved these changes May 27, 2021

View reviewed changes

benwgreen approved these changes May 27, 2021

View reviewed changes

dustinswales approved these changes May 27, 2021

View reviewed changes

climbfuji removed do not merge work in progress labels May 27, 2021

climbfuji mentioned this pull request May 27, 2021

Compositing z0 for fractional grid #579

Closed

climbfuji merged commit 24cc09e into NCAR:main May 27, 2021

This was referenced May 27, 2021

Redundant surface variable cleanup #659

Closed

Remove snet from Noah LSM #669

Closed

climbfuji mentioned this pull request Jul 22, 2021

Compositing z0 for fractional grid #578

Closed

This was referenced Nov 18, 2021

Changes to FV3 for ccpp-physics #782 NOAA-EMC/ufsatm#428

Merged

Changes to RRTMGP. New ORTs ufs-community/ufs-weather-model#926

Closed

RRTMGP cleanup from ORTs #782

Merged

DeniseWorthen mentioned this pull request Dec 2, 2021

Update Prototype test suite to initial P8 configuration; turn on RRTMGP ufs-community/ufs-weather-model#941

Closed

16 tasks

climbfuji deleted the move_sfc_emis_alb_calculation_to_its_own_scheme_and_z0_composite_consistent branch June 27, 2022 03:19

Conversation

climbfuji commented Apr 15, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Testing

Dependencies

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

benwgreen Apr 19, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

climbfuji commented May 20, 2021

Uh oh!

HelinWei-NOAA commented May 20, 2021 via email

Uh oh!

tanyasmirnova commented May 20, 2021

Uh oh!

climbfuji commented May 26, 2021

Uh oh!

tanyasmirnova left a comment

Choose a reason for hiding this comment

Uh oh!

benwgreen commented May 27, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

climbfuji commented May 27, 2021

Uh oh!

ShanSunNOAA left a comment

Choose a reason for hiding this comment

Uh oh!

HelinWei-NOAA commented May 27, 2021

Uh oh!

climbfuji commented May 27, 2021 via email

Uh oh!

dustinswales left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

climbfuji commented Apr 15, 2021 •

edited

Loading

benwgreen Apr 19, 2021 •

edited

Loading

benwgreen commented May 27, 2021 •

edited

Loading