Skip to content

Move sfc emis alb calculation to its own scheme and z0 composite consistent #627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
climbfuji merged 57 commits into from
May 27, 2021
Merged

Move sfc emis alb calculation to its own scheme and z0 composite consistent #627

Show file tree
Hide file tree
Changes from 18 commits
Commits
Show all changes
57 commits
Select commit Hold shift + click to select a range
756f2cf
Consistent use of emissivity and albedo between RUC LSM and the
tanyasmirnova Mar 26, 2021
67ddbbd
Merged Moorthi's changes for fractional grid in setemis.
tanyasmirnova Mar 26, 2021
25611d7
Step forward towards fractional albedo and emissivity in the LSM option.
tanyasmirnova Mar 30, 2021
25f789f
Merge pull request #83 from climbfuji/update_gsl_develop_from_master_…
DomHeinzeller Apr 1, 2021
21df401
Fix CODEOWNERS
climbfuji Apr 1, 2021
ed7db4d
Added initialization of 4 albedo components over land and ice to
tanyasmirnova Apr 5, 2021
ad1ad67
Change intent from out to inout for albedo.
tanyasmirnova Apr 5, 2021
ea0c6f0
Fixed problems with the initialization of albedo and emissivity.
tanyasmirnova Apr 8, 2021
b7cbcce
Merge branch 'gsl/develop' of https://github.com/NOAA-GSL/ccpp-physic…
tanyasmirnova Apr 8, 2021
d4531cd
Added the code to compute land, water and ice fractions when
tanyasmirnova Apr 9, 2021
e140651
Adding composite changes on top of Tanya's changes
Apr 12, 2021
efcc07c
Merge branch 'bwg_frac_emiss_albedo' of https://github.com/benwgreen/…
climbfuji Apr 13, 2021
e871573
Move calculation of surface albedo/emissivity out of rrtmg(p) pre sch…
climbfuji Apr 15, 2021
c4e0873
Add initialization of water vapor mixing ratio at the surface to
tanyasmirnova Apr 16, 2021
cbbafc5
Bug fix in the composite for ialb=2 option.
tanyasmirnova Apr 16, 2021
8367123
Move call to 'stability' for composites from sfc_diff to GFS_surface_…
climbfuji Apr 19, 2021
823f6ed
Merge branch 'master' of https://github.com/NCAR/ccpp-physics into mo…
climbfuji Apr 19, 2021
ff766e5
Fix merge conflicts
climbfuji Apr 19, 2021
1a2d365
Bugfix in physics/GFS_phys_time_vary.fv3.F90: remove old variables fr…
climbfuji Apr 19, 2021
a6ade33
physics/GFS_surface_composites.F90: move computation of cmm and chh a…
climbfuji Apr 19, 2021
d83c1a1
Add fractional code to ialb=1 option used with the Noah LSM.
tanyasmirnova Apr 19, 2021
21c87c4
Address reviewer comments
climbfuji Apr 19, 2021
7525515
Merge branch 'move_sfc_emis_alb_calculation_to_its_own_scheme_and_z0_…
climbfuji Apr 19, 2021
4f4be0e
Fix bugs in latest ialbflg==1 code, provide CPP option to switch betw…
climbfuji Apr 19, 2021
0119e95
Small bug fixes and changes in comments in setalb for ialb=1 or 2.
tanyasmirnova Apr 21, 2021
11daddb
Removed t1 from lsm_ruc_init. Some clean-up.
tanyasmirnova Apr 21, 2021
0fc7b40
Merge pull request #9 from tanyasmirnova/move_sfc_emis_alb_calculatio…
climbfuji Apr 22, 2021
2ed6a7c
Add missing dependency to physics/GFS_surface_composites.meta
climbfuji Apr 26, 2021
b51c5b3
Removing GSD_SURFACE_FLUXES_BUGFIX and replacing with flag thsfc_loc
Apr 26, 2021
b6d0ede
Bugfix
Apr 26, 2021
986211f
Merge pull request #10 from benwgreen/thsfc_loc2
climbfuji Apr 26, 2021
d2100a4
Add missing variables to physics/GFS_surface_composites.*
climbfuji Apr 26, 2021
45849a9
Only do 4th call to stability if multiple surface types exist
Apr 28, 2021
1477edd
Merge pull request #11 from benwgreen/composite_bugfix
climbfuji Apr 28, 2021
5be81f1
Merge branch 'move_sfc_emis_alb_calculation_to_its_own_scheme_and_z0_…
tanyasmirnova Apr 28, 2021
5da36fc
Removed interstitial variable from lsm_ruc_init.
tanyasmirnova Apr 28, 2021
a46ae1a
Merge pull request #12 from tanyasmirnova/move_sfc_emis_alb_calculati…
climbfuji Apr 28, 2021
55b4733
Merge branch 'master' of https://github.com/NCAR/ccpp-physics into mo…
climbfuji May 12, 2021
d224b13
Added option for ice on lakes.
tanyasmirnova May 13, 2021
c31b1ba
Merge pull request #13 from tanyasmirnova/move_sfc_emis_alb_calculati…
climbfuji May 14, 2021
e0b1eb6
Return earlier from physics/GFS_radiation_surface.F90 if sw/lw radiat…
climbfuji May 14, 2021
0918b56
physics/GFS_radiation_surface.*: do not reset alb/emis to zero when l…
climbfuji May 14, 2021
79739c7
physics/GFS_phys_time_vary.fv3.*: bug fix, do not initialize sfcalb/s…
climbfuji May 15, 2021
ec07fc0
Updates and bugfixes in physics/GFS_debug.F90
climbfuji May 17, 2021
f1e2db9
Bug fix in physics/sfc_drv_ruc.* to get b4b reproducible results in r…
climbfuji May 17, 2021
1a8a1bf
Remove option to revert to old iemis=1/ialb=1 calculation in physics/…
climbfuji May 18, 2021
c661a57
Bug fix in physics/GFS_phys_time_vary.fv3.meta: use correct horizonta…
climbfuji May 18, 2021
60b873f
Merge branch 'main' of https://github.com/NCAR/ccpp-physics into move…
climbfuji May 18, 2021
329364b
copy GFS_phys_time_vary.fv3.F90/meta changes over to SCM versions
grantfirl May 18, 2021
7468bf8
Merge branch 'move_sfc_emis_alb_calculation_to_its_own_scheme_and_z0_…
grantfirl May 18, 2021
a20fc32
Merge pull request #14 from grantfirl/move_sfc_emis_alb_calculation_t…
climbfuji May 18, 2021
38f28a2
Update metadata for ztmax variables
climbfuji May 18, 2021
c3375bb
Removed SNET. Net sloar radiation is computed from the incoming SW and
tanyasmirnova May 25, 2021
01bb2d5
Merge pull request #15 from tanyasmirnova/move_sfc_emis_alb_calculati…
climbfuji May 25, 2021
0a8aa3a
Add timestep_init andd timestep_final versions of GFS_diagtoscreen an…
climbfuji May 25, 2021
a6df017
Merge branch 'main' of https://github.com/NCAR/ccpp-physics into move…
climbfuji May 25, 2021
0350697
Bug fixes in several metadata files: use horizontal_dimension in _ini…
climbfuji May 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion physics/GFS_debug.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1232,7 +1232,6 @@ subroutine GFS_interstitialtoscreen_run (Model, Statein, Stateout, Sfcprop, Coup
call print_var(mpirank, omprank, blkno, Grid%xlat_d, Grid%xlon_d, 'Interstitial%tsfc_land ', Interstitial%tsfc_land )
call print_var(mpirank, omprank, blkno, Grid%xlat_d, Grid%xlon_d, 'Interstitial%tsfc_water ', Interstitial%tsfc_water )
call print_var(mpirank, omprank, blkno, Grid%xlat_d, Grid%xlon_d, 'Interstitial%tsfg ', Interstitial%tsfg )
call print_var(mpirank, omprank, blkno, Grid%xlat_d, Grid%xlon_d, 'Interstitial%tsurf ', Interstitial%tsurf )
call print_var(mpirank, omprank, blkno, Grid%xlat_d, Grid%xlon_d, 'Interstitial%tsurf_ice ', Interstitial%tsurf_ice )
call print_var(mpirank, omprank, blkno, Grid%xlat_d, Grid%xlon_d, 'Interstitial%tsurf_land ', Interstitial%tsurf_land )
call print_var(mpirank, omprank, blkno, Grid%xlat_d, Grid%xlon_d, 'Interstitial%tsurf_water ', Interstitial%tsurf_water )
Expand All @@ -1256,6 +1255,9 @@ subroutine GFS_interstitialtoscreen_run (Model, Statein, Stateout, Sfcprop, Coup
call print_var(mpirank, omprank, blkno, Grid%xlat_d, Grid%xlon_d, 'Interstitial%xmu ', Interstitial%xmu )
call print_var(mpirank, omprank, blkno, Grid%xlat_d, Grid%xlon_d, 'Interstitial%z01d ', Interstitial%z01d )
call print_var(mpirank, omprank, blkno, Grid%xlat_d, Grid%xlon_d, 'Interstitial%zt1d ', Interstitial%zt1d )
call print_var(mpirank, omprank, blkno, Grid%xlat_d, Grid%xlon_d, 'Interstitial%ztmax_ice ', Interstitial%ztmax_ice )
call print_var(mpirank, omprank, blkno, Grid%xlat_d, Grid%xlon_d, 'Interstitial%ztmax_land ', Interstitial%ztmax_land )
call print_var(mpirank, omprank, blkno, Grid%xlat_d, Grid%xlon_d, 'Interstitial%ztmax_water ', Interstitial%ztmax_water )
! UGWP
call print_var(mpirank, omprank, blkno, Grid%xlat_d, Grid%xlon_d, 'Interstitial%tau_mtb ', Interstitial%tau_mtb )
call print_var(mpirank, omprank, blkno, Grid%xlat_d, Grid%xlon_d, 'Interstitial%tau_ogw ', Interstitial%tau_ogw )
Expand Down
65 changes: 48 additions & 17 deletions physics/GFS_phys_time_vary.fv3.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,8 @@ subroutine GFS_phys_time_vary_init (
isot, ivegsrc, nlunit, sncovr, sncovr_ice, lsm, lsm_noahmp, lsm_ruc, min_seaice, &
fice, landfrac, vtype, weasd, lsoil, zs, dzs, lsnow_lsm_lbound, lsnow_lsm_ubound, &
tvxy, tgxy, tahxy, canicexy, canliqxy, eahxy, cmxy, chxy, fwetxy, sneqvoxy, alboldxy,&
qsnowxy, wslakexy, albdvis, albdnir, albivis, albinir, emiss, taussxy, waxy, wtxy, &
qsnowxy, wslakexy, albdvis_lnd, albdnir_lnd, albivis_lnd, albinir_lnd, albdvis_ice, &
albdnir_ice, albivis_ice, albinir_ice, emiss_lnd, emiss_ice, taussxy, waxy, wtxy, &
zwtxy, xlaixy, xsaixy, lfmassxy, stmassxy, rtmassxy, woodxy, stblcpxy, fastcpxy, &
smcwtdxy, deeprechxy, rechxy, snowxy, snicexy, snliqxy, tsnoxy , smoiseq, zsnsoxy, &
slc, smc, stc, tsfcl, snowd, canopy, tg3, stype, con_t0c, nthrds, errmsg, errflg)
Expand Down Expand Up @@ -125,11 +126,16 @@ subroutine GFS_phys_time_vary_init (
real(kind_phys), intent(inout) :: alboldxy(:)
real(kind_phys), intent(inout) :: qsnowxy(:)
real(kind_phys), intent(inout) :: wslakexy(:)
real(kind_phys), intent(inout) :: albdvis(:)
real(kind_phys), intent(inout) :: albdnir(:)
real(kind_phys), intent(inout) :: albivis(:)
real(kind_phys), intent(inout) :: albinir(:)
real(kind_phys), intent(inout) :: emiss(:)
real(kind_phys), intent(inout) :: albdvis_lnd(:)
real(kind_phys), intent(inout) :: albdnir_lnd(:)
real(kind_phys), intent(inout) :: albivis_lnd(:)
real(kind_phys), intent(inout) :: albinir_lnd(:)
real(kind_phys), intent(inout) :: albdvis_ice(:)
real(kind_phys), intent(inout) :: albdnir_ice(:)
real(kind_phys), intent(inout) :: albivis_ice(:)
real(kind_phys), intent(inout) :: albinir_ice(:)
real(kind_phys), intent(inout) :: emiss_lnd(:)
real(kind_phys), intent(inout) :: emiss_ice(:)
real(kind_phys), intent(inout) :: taussxy(:)
real(kind_phys), intent(inout) :: waxy(:)
real(kind_phys), intent(inout) :: wtxy(:)
Expand Down Expand Up @@ -385,6 +391,41 @@ subroutine GFS_phys_time_vary_init (
if (errflg/=0) return
end if

!--- For Noah MP or RUC LSMs: initialize four components of albedo for

@grantfirl grantfirl May 14, 2021

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@climbfuji This change should also go into the SCM version of this scheme. Should I do a follow-up SCM-only PR that includes these changes or add them to this PR (which of course should not affect UFS RTs in any way)?

@climbfuji climbfuji May 14, 2021

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can create a PR for my branch and we can merge it together. Note that I am just working on a bugfix/update of this code, because it should only be executed when the model is cold started.

!--- land and ice
if (lsm == lsm_noahmp .or. lsm == lsm_ruc) then
if (me == master ) write(0,'(a)') 'GFS_phys_time_vary_init: initialize albedo for land and ice'
albdvis_lnd(:) = missing_value
albdnir_lnd(:) = missing_value
albivis_lnd(:) = missing_value
albinir_lnd(:) = missing_value
emiss_lnd(:) = missing_value

do ix=1,im
albdvis_lnd(ix) = 0.2_kind_phys
albdnir_lnd(ix) = 0.2_kind_phys
albivis_lnd(ix) = 0.2_kind_phys
albinir_lnd(ix) = 0.2_kind_phys
emiss_lnd(ix) = 0.95_kind_phys
enddo
endif

@grantfirl grantfirl May 14, 2021

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor code-readability quibble: the if/endif pairs do not line up, which can make this logic more confusing than it needs to be.

@climbfuji climbfuji May 14, 2021

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This contains unneccessary code as well, I am cleaning it up as part of the bugfix for restart runs.


if (lsm == lsm_ruc) then
albdvis_ice(:) = missing_value
albdnir_ice(:) = missing_value
albivis_ice(:) = missing_value
albinir_ice(:) = missing_value
emiss_ice(:) = missing_value

do ix=1,im
albdvis_ice(ix) = 0.6_kind_phys
albdnir_ice(ix) = 0.6_kind_phys
albivis_ice(ix) = 0.6_kind_phys
albinir_ice(ix) = 0.6_kind_phys
emiss_ice(ix) = 0.97_kind_phys
enddo
endif

if (lsm == lsm_noahmp) then
if (all(tvxy < zero)) then

Expand All @@ -406,11 +447,6 @@ subroutine GFS_phys_time_vary_init (
alboldxy(:) = missing_value
qsnowxy(:) = missing_value
wslakexy(:) = missing_value
albdvis(:) = missing_value
albdnir(:) = missing_value
albivis(:) = missing_value
albinir(:) = missing_value
emiss(:) = missing_value
taussxy(:) = missing_value
waxy(:) = missing_value
wtxy(:) = missing_value
Expand Down Expand Up @@ -441,7 +477,7 @@ subroutine GFS_phys_time_vary_init (
!$OMP shared(im,lsoil,con_t0c,landfrac,tsfcl,tvxy,tgxy,tahxy) &
!$OMP shared(snowd,canicexy,canliqxy,canopy,eahxy,cmxy,chxy) &
!$OMP shared(fwetxy,sneqvoxy,weasd,alboldxy,qsnowxy,wslakexy) &
!$OMP shared(taussxy,albdvis,albdnir,albivis,albinir,emiss) &
!$OMP shared(taussxy) &
!$OMP shared(waxy,wtxy,zwtxy,imn,vtype,xlaixy,xsaixy,lfmassxy) &
!$OMP shared(stmassxy,rtmassxy,woodxy,stblcpxy,fastcpxy) &
!$OMP shared(isbarren_table,isice_table,isurban_table) &
Expand Down Expand Up @@ -480,11 +516,6 @@ subroutine GFS_phys_time_vary_init (
! already set to 0.0
wslakexy(ix) = zero
taussxy(ix) = zero
albdvis(ix) = 0.2_kind_phys
albdnir(ix) = 0.2_kind_phys
albivis(ix) = 0.2_kind_phys
albinir(ix) = 0.2_kind_phys
emiss(ix) = 0.95_kind_phys

waxy(ix) = 4900.0_kind_phys
wtxy(ix) = waxy(ix)
Expand Down
85 changes: 65 additions & 20 deletions physics/GFS_phys_time_vary.fv3.meta
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -755,47 +755,92 @@
kind = kind_phys
intent = inout
optional = F
[albdvis]
standard_name = surface_albedo_direct_visible
long_name = direct surface albedo visible band
[albdvis_lnd]
standard_name = surface_albedo_direct_visible_over_land
long_name = direct surface albedo visible band over land
units = frac
dimensions = (horizontal_dimension)
dimensions = (horizontal_loop_extent)

@grantfirl grantfirl May 18, 2021

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since these changes correspond to the init stage, shouldn't the dimensions be 'horizontal_dimension' instead of 'horizontal_loop_extent'? (same for all changes in this file)

@climbfuji climbfuji May 18, 2021

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, Grant. Fixed.

type = real
kind = kind_phys
intent = inout
optional = F
[albdnir]
standard_name = surface_albedo_direct_NIR
long_name = direct surface albedo NIR band
[albdnir_lnd]
standard_name = surface_albedo_direct_NIR_over_land
long_name = direct surface albedo NIR band over land
units = frac
dimensions = (horizontal_dimension)
dimensions = (horizontal_loop_extent)
type = real
kind = kind_phys
intent = inout
optional = F
[albivis]
standard_name = surface_albedo_diffuse_visible
long_name = diffuse surface albedo visible band
[albivis_lnd]
standard_name = surface_albedo_diffuse_visible_over_land
long_name = diffuse surface albedo visible band over land
units = frac
dimensions = (horizontal_dimension)
dimensions = (horizontal_loop_extent)
type = real
kind = kind_phys
intent = inout
optional = F
[albinir]
standard_name = surface_albedo_diffuse_NIR
long_name = diffuse surface albedo NIR band
[albinir_lnd]
standard_name = surface_albedo_diffuse_NIR_over_land
long_name = diffuse surface albedo NIR band over land
units = frac
dimensions = (horizontal_dimension)
dimensions = (horizontal_loop_extent)
type = real
kind = kind_phys
intent = inout
optional = F
[emiss]
standard_name = surface_emissivity_lsm
long_name = surface emissivity from lsm
[albdvis_ice]
standard_name = surface_albedo_direct_visible_over_ice
long_name = direct surface albedo visible band over ice
units = frac
dimensions = (horizontal_dimension)
dimensions = (horizontal_loop_extent)
type = real
kind = kind_phys
intent = inout
optional = F
[albdnir_ice]
standard_name = surface_albedo_direct_NIR_over_ice
long_name = direct surface albedo NIR band over ice
units = frac
dimensions = (horizontal_loop_extent)
type = real
kind = kind_phys
intent = inout
optional = F
[albivis_ice]
standard_name = surface_albedo_diffuse_visible_over_ice
long_name = diffuse surface albedo visible band over ice
units = frac
dimensions = (horizontal_loop_extent)
type = real
kind = kind_phys
intent = inout
optional = F
[albinir_ice]
standard_name = surface_albedo_diffuse_NIR_over_ice
long_name = diffuse surface albedo NIR band over ice
units = frac
dimensions = (horizontal_loop_extent)
type = real
kind = kind_phys
intent = inout
optional = F
[emiss_lnd]
standard_name = surface_longwave_emissivity_over_land
long_name = surface lw emissivity in fraction over land
units = frac
dimensions = (horizontal_loop_extent)
type = real
kind = kind_phys
intent = inout
optional = F
[emiss_ice]
standard_name = surface_longwave_emissivity_over_ice
long_name = surface lw emissivity in fraction over ice
units = frac
dimensions = (horizontal_loop_extent)
type = real
kind = kind_phys
intent = inout
Expand Down
Loading