-
Notifications
You must be signed in to change notification settings - Fork 169
Move sfc emis alb calculation to its own scheme and z0 composite consistent #627
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
climbfuji
merged 57 commits into
NCAR:main
from
climbfuji:move_sfc_emis_alb_calculation_to_its_own_scheme_and_z0_composite_consistent
May 27, 2021
Merged
Changes from 51 commits
Commits
Show all changes
57 commits
Select commit
Hold shift + click to select a range
756f2cf
Consistent use of emissivity and albedo between RUC LSM and the
tanyasmirnova 67ddbbd
Merged Moorthi's changes for fractional grid in setemis.
tanyasmirnova 25611d7
Step forward towards fractional albedo and emissivity in the LSM option.
tanyasmirnova 25f789f
Merge pull request #83 from climbfuji/update_gsl_develop_from_master_…
DomHeinzeller 21df401
Fix CODEOWNERS
climbfuji ed7db4d
Added initialization of 4 albedo components over land and ice to
tanyasmirnova ad1ad67
Change intent from out to inout for albedo.
tanyasmirnova ea0c6f0
Fixed problems with the initialization of albedo and emissivity.
tanyasmirnova b7cbcce
Merge branch 'gsl/develop' of https://github.com/NOAA-GSL/ccpp-physic…
tanyasmirnova d4531cd
Added the code to compute land, water and ice fractions when
tanyasmirnova e140651
Adding composite changes on top of Tanya's changes
efcc07c
Merge branch 'bwg_frac_emiss_albedo' of https://github.com/benwgreen/…
climbfuji e871573
Move calculation of surface albedo/emissivity out of rrtmg(p) pre sch…
climbfuji c4e0873
Add initialization of water vapor mixing ratio at the surface to
tanyasmirnova cbbafc5
Bug fix in the composite for ialb=2 option.
tanyasmirnova 8367123
Move call to 'stability' for composites from sfc_diff to GFS_surface_…
climbfuji 823f6ed
Merge branch 'master' of https://github.com/NCAR/ccpp-physics into mo…
climbfuji ff766e5
Fix merge conflicts
climbfuji 1a2d365
Bugfix in physics/GFS_phys_time_vary.fv3.F90: remove old variables fr…
climbfuji a6ade33
physics/GFS_surface_composites.F90: move computation of cmm and chh a…
climbfuji d83c1a1
Add fractional code to ialb=1 option used with the Noah LSM.
tanyasmirnova 21c87c4
Address reviewer comments
climbfuji 7525515
Merge branch 'move_sfc_emis_alb_calculation_to_its_own_scheme_and_z0_…
climbfuji 4f4be0e
Fix bugs in latest ialbflg==1 code, provide CPP option to switch betw…
climbfuji 0119e95
Small bug fixes and changes in comments in setalb for ialb=1 or 2.
tanyasmirnova 11daddb
Removed t1 from lsm_ruc_init. Some clean-up.
tanyasmirnova 0fc7b40
Merge pull request #9 from tanyasmirnova/move_sfc_emis_alb_calculatio…
climbfuji 2ed6a7c
Add missing dependency to physics/GFS_surface_composites.meta
climbfuji b51c5b3
Removing GSD_SURFACE_FLUXES_BUGFIX and replacing with flag thsfc_loc
b6d0ede
Bugfix
986211f
Merge pull request #10 from benwgreen/thsfc_loc2
climbfuji d2100a4
Add missing variables to physics/GFS_surface_composites.*
climbfuji 45849a9
Only do 4th call to stability if multiple surface types exist
1477edd
Merge pull request #11 from benwgreen/composite_bugfix
climbfuji 5be81f1
Merge branch 'move_sfc_emis_alb_calculation_to_its_own_scheme_and_z0_…
tanyasmirnova 5da36fc
Removed interstitial variable from lsm_ruc_init.
tanyasmirnova a46ae1a
Merge pull request #12 from tanyasmirnova/move_sfc_emis_alb_calculati…
climbfuji 55b4733
Merge branch 'master' of https://github.com/NCAR/ccpp-physics into mo…
climbfuji d224b13
Added option for ice on lakes.
tanyasmirnova c31b1ba
Merge pull request #13 from tanyasmirnova/move_sfc_emis_alb_calculati…
climbfuji e0b1eb6
Return earlier from physics/GFS_radiation_surface.F90 if sw/lw radiat…
climbfuji 0918b56
physics/GFS_radiation_surface.*: do not reset alb/emis to zero when l…
climbfuji 79739c7
physics/GFS_phys_time_vary.fv3.*: bug fix, do not initialize sfcalb/s…
climbfuji ec07fc0
Updates and bugfixes in physics/GFS_debug.F90
climbfuji f1e2db9
Bug fix in physics/sfc_drv_ruc.* to get b4b reproducible results in r…
climbfuji 1a8a1bf
Remove option to revert to old iemis=1/ialb=1 calculation in physics/…
climbfuji c661a57
Bug fix in physics/GFS_phys_time_vary.fv3.meta: use correct horizonta…
climbfuji 60b873f
Merge branch 'main' of https://github.com/NCAR/ccpp-physics into move…
climbfuji 329364b
copy GFS_phys_time_vary.fv3.F90/meta changes over to SCM versions
grantfirl 7468bf8
Merge branch 'move_sfc_emis_alb_calculation_to_its_own_scheme_and_z0_…
grantfirl a20fc32
Merge pull request #14 from grantfirl/move_sfc_emis_alb_calculation_t…
climbfuji 38f28a2
Update metadata for ztmax variables
climbfuji c3375bb
Removed SNET. Net sloar radiation is computed from the incoming SW and
tanyasmirnova 01bb2d5
Merge pull request #15 from tanyasmirnova/move_sfc_emis_alb_calculati…
climbfuji 0a8aa3a
Add timestep_init andd timestep_final versions of GFS_diagtoscreen an…
climbfuji a6df017
Merge branch 'main' of https://github.com/NCAR/ccpp-physics into move…
climbfuji 0350697
Bug fixes in several metadata files: use horizontal_dimension in _ini…
climbfuji File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@climbfuji This change should also go into the SCM version of this scheme. Should I do a follow-up SCM-only PR that includes these changes or add them to this PR (which of course should not affect UFS RTs in any way)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can create a PR for my branch and we can merge it together. Note that I am just working on a bugfix/update of this code, because it should only be executed when the model is cold started.