Update master from NOAA-GSL: RUC ice, MYNN sfclay, stochastic land perturbations by climbfuji · Pull Request #558 · NCAR/ccpp-physics

climbfuji · 2021-01-20T16:51:48Z

Changes in this PR:

bugfixes and updates to MYNN sfclay (fixes several uninitialized variables0
addition of RUC ICE (replaces sfc_sice when RUC LSM is used)
land surface perturbations (requires assigning local variables minsmc and maxsmc to host model in order to pass to stochastic physics)
remove unused tracer_sanitizer

For testing, see ufs-community/ufs-weather-model#386

Associated PRs:

NOAA-PSL/stochastic_physics#36
#558
NOAA-EMC/ufsatm#239
ufs-community/ufs-weather-model#386

updating fork

ice is added to sfc_drv_ruc.F90.

parameters of lsm_ruc_run. There are not needed there because initialization of RUC soil variables is done now in lsm_ruc_init.

updating fork

…3,scm}.F90

…emove unneeded acsnow

Suggested changes to rucice PR

…ter_20201118 Update gsd/develop from master 2020/11/18

…pp-physics into rucice_gsl_develop

RUC ice for gsl/develop (replaces NCAR#57 and NCAR#63)

…ter_20201203 Update gsl/develop from master 2020/12/08

update branch

…using unitialized variable when 100% ice melts or ice develops on a grid with 0% ice, 3) reduced overly liberal range of allowable z/L.

updating from gsl/develop instead of gsd/develop

Updates to the MYNN surface layer scheme

GFS_Control_type arrays pores and resid for use in the stochastic perturbations of soil moisture (lndp_type=2).

Added initialization of pores and resid

…umed sizes for 3D tendency arrays

…encies Bugfixes for Shinhong and YSU 3d tendency arrays

…ed variables

…elop_dom_20210116 Bugfix in physics/GFS_debug.F90: remove/comment out unused variables

grantfirl · 2021-01-21T15:25:26Z

+         ! initialize tables for psih and psim (stable and unstable)
+         CALL PSI_INIT(psi_opt,errmsg,errflg)
+
+         IF (debug_code >= 1) THEN


Thanks for controlling print statements with a debug flag -- a very good example to follow.

You are welcome

grantfirl

I don't understand the "whys" of the code changes since there isn't a ton of description other than "bugfixes", but I definitely don't see anything wrong from a CCPP point of view. Approved.

llpcarson

looks ok to me, approved.

climbfuji · 2021-01-21T15:49:17Z

I don't understand the "whys" of the code changes since there isn't a ton of description other than "bugfixes", but I definitely don't see anything wrong from a CCPP point of view. Approved.

Thanks, Grant. Yes, MYNN has bugfixes and updates as noted in the description of the PR. All the other changes that are not related to MYNN arae hopefully captured in the description.

…NCAR#558) * update upp revision to 8767929 * modify dx/dy calculation for RRFS with domain over north pole

joeolson42 and others added 30 commits September 2, 2020 09:37

Merge pull request #5 from NOAA-GSD/gsd/develop

14e59ca

updating fork

Reinstated sea ice option in RUC LSM. Additional CALL to LSMRUC for sea

590d110

ice is added to sfc_drv_ruc.F90.

Albedo computation fixes for RUC ice to get a successful run.

2080766

Noah soil variables (smc,stc,slc) are removed from the list of

394dfa5

parameters of lsm_ruc_run. There are not needed there because initialization of RUC soil variables is done now in lsm_ruc_init.

Removed Noah soil variables from sfc_drv_ruc.meta as well.

13bf350

Bug fix from Dom.

9a53be6

Merge pull request #6 from NOAA-GSD/gsd/develop

9c23523

updating fork

Bug fix in hydraulic conductivity computation.

58bee86

A version that uses local arrays for albedo over land and ice.

7b0434b

Fix uninitialized variable mvd_r in physics/module_mp_thompson.F90

e3f7f64

Add reminders for sncovr_ice initialization to GFS_phys_time_vary.{fv…

8b3545a

…3,scm}.F90

physics/sfc_drv_ruc.{F90,meta}: use local variables where possible, r…

f2291a5

…emove unneeded acsnow

Update physics/GFS_debug.F90 with changes to RUC LSM arrays

ea8b130

Remove physics/lsm_ruc_sfc_sice_interstitial.F90

e6cac7b

Merge pull request #3 from climbfuji/dom_rucice_for_tanya

dccce95

Suggested changes to rucice PR

Merge pull request NCAR#62 from climbfuji/update_gsd_develop_from_mas…

7fa0ec8

…ter_20201118 Update gsd/develop from master 2020/11/18

Bugfixes in RUC LSM for land-ice implementation

83654f1

Update MYNN surface layer scheme to work with RUC ICE

dc007b0

Update CODEOWNERS for gsl/develop branch

d12329a

Merge branch 'ruclsm_bugfixes_dom' of https://github.com/climbfuji/cc…

da2b6ff

…pp-physics into rucice_gsl_develop

Remove lsm_ruc_sfc_sice_interstitial from source code and documentation

63742d4

Remove sfc_sice from physics/docs/pdftxt/GSD_adv_suite.txt

11fc839

Merge pull request NCAR#65 from climbfuji/rucice_gsl_develop

bafcc9e

RUC ice for gsl/develop (replaces NCAR#57 and NCAR#63)

Merge branch 'master' of https://github.com/NCAR/ccpp-physics into HEAD

e41f9a8

Merge pull request NCAR#66 from climbfuji/update_gsl_develop_from_mas…

91b7726

…ter_20201203 Update gsl/develop from master 2020/12/08

Merge pull request #7 from NOAA-GSL/gsd/develop

13b8d8d

update branch

Updates to mynn sfc layer: 1) bugfix for init routine, 2) bugfix for …

beeb14e

…using unitialized variable when 100% ice melts or ice develops on a grid with 0% ice, 3) reduced overly liberal range of allowable z/L.

Merge pull request #8 from NOAA-GSL/gsl/develop

2dafd6b

updating from gsl/develop instead of gsd/develop

Merge pull request NCAR#67 from joeolson42/gsd/develop

0ac8068

Updates to the MYNN surface layer scheme

The max and min soil moisture for a given soil type is saved in the

96cce1f

GFS_Control_type arrays pores and resid for use in the stochastic perturbations of soil moisture (lndp_type=2).

tanyasmirnova and others added 8 commits December 29, 2020 17:17

Add machine(kind_physics) ti init.

b52215c

Remove tracer_sanitizer*

0bc4b34

Merge pull request NCAR#71 from tanyasmirnova/gsl_landstoch_withruc

acf281a

Added initialization of pores and resid

Bugfixes in physics/shinhongvdif.F90 and physics/ysuvdif.F90: use ass…

dc7f954

…umed sizes for 3D tendency arrays

Merge pull request NCAR#75 from climbfuji/shinhong_ysu_bugfix_3d_tend…

042c61d

…encies Bugfixes for Shinhong and YSU 3d tendency arrays

Remove Diag%cldcov from physics/GFS_debug.F90, comment out other unus…

0dfdd8d

…ed variables

Merge pull request NCAR#76 from climbfuji/additional_bugfixes_gsl_dev…

1fd346f

…elop_dom_20210116 Bugfix in physics/GFS_debug.F90: remove/comment out unused variables

Merge branch 'master' of https://github.com/NCAR/ccpp-physics into HEAD

95ae408

climbfuji marked this pull request as ready for review January 20, 2021 17:48

climbfuji requested review from JulieSchramm, grantfirl and llpcarson as code owners January 20, 2021 17:48

climbfuji requested review from joeolson42 and tanyasmirnova January 20, 2021 23:03

grantfirl reviewed Jan 21, 2021

View reviewed changes

grantfirl approved these changes Jan 21, 2021

View reviewed changes

llpcarson approved these changes Jan 21, 2021

View reviewed changes

climbfuji merged commit 469cb90 into NCAR:master Jan 21, 2021

climbfuji deleted the update_master_from_gsl_develop branch June 27, 2022 03:30

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update master from NOAA-GSL: RUC ice, MYNN sfclay, stochastic land perturbations#558

Update master from NOAA-GSL: RUC ice, MYNN sfclay, stochastic land perturbations#558
climbfuji merged 38 commits into
NCAR:masterfrom
climbfuji:update_master_from_gsl_develop

climbfuji commented Jan 20, 2021 •

edited

Loading

Uh oh!

grantfirl Jan 21, 2021

Uh oh!

joeolson42 Jan 21, 2021

Uh oh!

grantfirl left a comment

Uh oh!

llpcarson left a comment

Uh oh!

climbfuji commented Jan 21, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

climbfuji commented Jan 20, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

grantfirl Jan 21, 2021

Choose a reason for hiding this comment

Uh oh!

joeolson42 Jan 21, 2021

Choose a reason for hiding this comment

Uh oh!

grantfirl left a comment

Choose a reason for hiding this comment

Uh oh!

llpcarson left a comment

Choose a reason for hiding this comment

Uh oh!

climbfuji commented Jan 21, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

climbfuji commented Jan 20, 2021 •

edited

Loading