ccpp-physics cleanup 20180402#66
Merged
Merged
Conversation
Collaborator
Author
|
TODO: test if this changes bit-for-bit results with FV3 |
Collaborator
Author
|
UPDATE: results are bit-for-bit identical on Cheyenne with Intel compiler. @llpcarson @grantfirl shall we play safe and wait for Theia to return from the maintenance for a final test? |
Contributor
|
I recommend we proceed --- the theia test can be completed before we push this to master. |
llpcarson
pushed a commit
to llpcarson/ccpp-physics
that referenced
this pull request
Dec 22, 2020
…ter_20201203 Update gsl/develop from master 2020/12/08
mkavulich
pushed a commit
to mkavulich/ccpp-physics
that referenced
this pull request
Jul 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR performs cleanup tasks: add initialization of CCPP error handling variables in physics/mfdeepcnv.f.