Fix noahmp driver TODO#7
Merged
climbfuji merged 2 commits intoFeb 26, 2021
Merged
Conversation
climbfuji
approved these changes
Feb 26, 2021
Owner
climbfuji
left a comment
climbfuji
left a comment
There was a problem hiding this comment.
This all looks good to me (with my limited understanding of the actual Noah MP code ...) , thanks for making those changes.
climbfuji
pushed a commit
that referenced
this pull request
Oct 22, 2021
Tiny doc update moorthi sep21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Let me know if this is not how you want to resolve these.