-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
styling for the absence page #660
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The styling looks good, but I cannot add absence using keyboard navigation (the start date disappears when the end date is entered), nor use the pen button to edit reported absence. Clicking the edit button changes the reported dates to one date next year (no span).
Also, there is a new dependency to something from gstatic.com which is not good. It appears when there is a planned absence: https://www.gstatic.com/charts/loader.js (initiated from patchWindow.js)
One strange thing is a hard-coded "max-date" for the date pickers (not new to this branch though).
The date picker should not appear when you navigate to a date field unless you tab and click on the calendar icon, or it should close when a date is entered and the user tabs to get to the next field.
Also found some accessibility errors regarding the table + warnings:
Warning: validateDOMNesting(...): tr cannot appear as a child of table. Add a tbody, thead or tfoot to your code to match the DOM tree generated by the browser.
"Empty heading" for empty th elements. Warning about empty button - "A button is empty or has no value text."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It'd be nice if we merge #656 first and then also style the date pickers in this pr. |
A lot to look into, I think most things can be addressed quickly. This part though... |
The problem with the date picker now is that when you enter the field using kbd it appears and the only way it seems to get rid of it is clicking Esc, which clears the field. It should work so that when you have entered a date and press tab you get to the next field (or the date picker icon/button). That is, keyboard navigation should work. |
Ah okay, I knew you had to click esc but didn't realize the field was cleared then. That broke somewhere during development. I'll fix that then. |
286076f
to
3437489
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Possible to release, but needs further work, soon.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work. We still need to style the edit date pickers, but that will be done later.
Related issue(s) and PR(s)
This PR closes #601
Type of change
List of changes made
Screenshot of the fix
Testing
Further comments
Definition of Done checklist