-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make it possible to edit existing absence periods #656
Conversation
This context will provide edit period dialog components.
Using the function useDates from the dialog provider
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
I can not see my own planned absence in the view's lower half graph:
-
The dates are not shown in the dialogue the first time a planned absence is edited. They are shown on subsequent edits.
First edit:
-
A note should be added (on the page or in the help text) saying exactly what ranges the planner is showing.
-
Help text is missing.
The main issue at the moment is that the dates for the planned absence is not shown in the dialogue the first time the user wants to edit the date range.
The adding, editing, and deleting seem to work well!
When I click "edit", I expect the dates to appear in the date fields for planning a new absence (including date pickers) instead of getting a new dialog that works differently. |
Also improve error handling.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now. The main issue that I found in my first review has been handled.
I'm merging this with the understanding that a help text will be added later. |
Related issue(s) and PR(s)
This PR closes #654
Type of change
List of changes made
Screenshot of the fix
Testing