Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it possible to edit existing absence periods #656

Merged
merged 5 commits into from
Sep 20, 2022

Conversation

jonandernovella
Copy link
Contributor

Related issue(s) and PR(s)

This PR closes #654

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

List of changes made

  • Added new provider for editing absence period dialogs
  • Reused the ModalDialog in the newly created provider
  • Make it possible to truly edit time entry ranges

Screenshot of the fix

bild

Testing

  • Click on the edit button of a absence range in the absence page and update the from and to dates.

This context will provide edit period dialog components.
Using the function useDates from the dialog provider
@jonandernovella jonandernovella requested a review from a team September 16, 2022 09:28
Copy link
Member

@kusalananda kusalananda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • I can not see my own planned absence in the view's lower half graph:
    image

  • The dates are not shown in the dialogue the first time a planned absence is edited. They are shown on subsequent edits.
    First edit:
    image

    Second (and subsequent) edit:
    image

  • A note should be added (on the page or in the help text) saying exactly what ranges the planner is showing.

  • Help text is missing.

The main issue at the moment is that the dates for the planned absence is not shown in the dialogue the first time the user wants to edit the date range.

The adding, editing, and deleting seem to work well!

@ghost
Copy link

ghost commented Sep 20, 2022

When I click "edit", I expect the dates to appear in the date fields for planning a new absence (including date pickers) instead of getting a new dialog that works differently.

Also improve error handling.
Copy link
Member

@kusalananda kusalananda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now. The main issue that I found in my first review has been handled.

@kusalananda
Copy link
Member

I'm merging this with the understanding that a help text will be added later.

@kusalananda kusalananda merged commit b66f74e into develop Sep 20, 2022
@kusalananda kusalananda deleted the dev/edit-dialog branch September 20, 2022 09:42
@jonandernovella jonandernovella mentioned this pull request Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Date pickers for editing absence period
2 participants