Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/footer #436

Merged
9 commits merged into from
May 13, 2022
Merged

Fix/footer #436

9 commits merged into from
May 13, 2022

Conversation

airenzp
Copy link
Contributor

@airenzp airenzp commented May 12, 2022

Related issue(s) and PR(s)

This PR closes #372 .

This PR makes the bottom bar always visible and merges the quick add and save changes section. The toast is now displayed to the right over the empty space area.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

List of changes made

Edited css and reorganized rendering of the quick and and save changes. Note that what looks like a lot of changes in the rendering of the report is caused because of removing the wrapper div.

Testing

Scroll, edit, save changes, to see the result

Definition of Done checklist

  • I have made an effort making the commit history understandable
  • I have performed a self-review of my own code and commented any hard-to-understand areas
  • Tests and lint/format validations are passing
  • My changes generate no new warnings

Copy link
Contributor

@jonandernovella jonandernovella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good progress! I think there are a few more things to work on though.

  • We need some paddings in the quick add container. See how close the "Quick Add" text is to the border.
  • The bottom bar could be splitted in two so that it's clear that the Save Changes button is not part of the Quick Add. I'd suggest that the grey background is only applied on the left side, that is where the Quick add belongs. Then the Save Changes would have a white background, making it feel more separate.

bild

Copy link
Member

@kusalananda kusalananda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only issue that I have is that the bar seems to be partially hidden beneath the bottom of the screen. Also, the + button appear to be missing (it may be below the bottom of the screen?).

Screenshot 2022-05-12 at 14-50-23 URDR timelogging

@airenzp
Copy link
Contributor Author

airenzp commented May 12, 2022

I added a commit. Fika time now :-). Let me know if it works better

@ghost
Copy link

ghost commented May 12, 2022

It is possible to zoom and make the browser window so small that the buttons at the bottom look a bit strange, but I cannot make them disappear now. It might not be perfect, but it is better than the develop version.

@kusalananda
Copy link
Member

I can see the + again, but the whole bar is still partially obscured below the end of the screen.

@ghost
Copy link

ghost commented May 12, 2022

The linter seems to complain about an empty line at line 261/262 in index.css.
The warning about a wrong url (style "header-warning") is hidden again, behind the top bar.

@ghost
Copy link

ghost commented May 12, 2022

Airen made some improvements and I added a fix to restore the header-warning for wrong url. I think this is ok for merge.
We should make the linter allow longhand notation in css.

@ghost ghost dismissed stale reviews from kusalananda and jonandernovella May 13, 2022 09:18

Issue adressed

@ghost ghost self-requested a review May 13, 2022 09:18
@ghost ghost merged commit 14e4a71 into develop May 13, 2022
@ghost ghost deleted the fix/footer branch May 13, 2022 09:37
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make top and bottom bar sticky
3 participants