-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/footer #436
Fix/footer #436
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good progress! I think there are a few more things to work on though.
- We need some paddings in the quick add container. See how close the "Quick Add" text is to the border.
- The bottom bar could be splitted in two so that it's clear that the Save Changes button is not part of the Quick Add. I'd suggest that the grey background is only applied on the left side, that is where the Quick add belongs. Then the Save Changes would have a white background, making it feel more separate.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a commit. Fika time now :-). Let me know if it works better |
It is possible to zoom and make the browser window so small that the buttons at the bottom look a bit strange, but I cannot make them disappear now. It might not be perfect, but it is better than the develop version. |
I can see the |
The linter seems to complain about an empty line at line 261/262 in index.css. |
Airen made some improvements and I added a fix to restore the header-warning for wrong url. I think this is ok for merge. |
We updated the height of the overlay so that is relative to the viewport and adjusted the position of the toast.
928aa2e
to
204aaac
Compare
Issue adressed
Related issue(s) and PR(s)
This PR closes #372 .
This PR makes the bottom bar always visible and merges the quick add and save changes section. The toast is now displayed to the right over the empty space area.
Type of change
List of changes made
Edited css and reorganized rendering of the quick and and save changes. Note that what looks like a lot of changes in the rendering of the report is caused because of removing the wrapper div.
Testing
Scroll, edit, save changes, to see the result
Definition of Done checklist