Berkeley #15415
Merged
Berkeley #15415
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
!ci-toolchain-me |
|
|
…-2024-apr03 Fix HF unit test after compatible update
…ley-migration Update nix files to build berkeley migration tools
Devnet HF stop slots
compatible: support devnet channel
…ELEY [berkeley] Devnet HF stop slots #15443
* Make runtime_genesis_ledger stricter in accepting configs * Remove nonsense from runtime_config when loading epoch_data ledgers
Problem: parameter is clearly redundant Solution: take the value from the fork config
Problem: migration verifier tool and migration script incorrectly named genesis config of the fork network as the fork config which introduced certain confusion. Solution: rename all such occurences of fork config to fork genesis config.
Berkley Package Verification Documentation Upgrade
…-docs Sai/berk pkg verification docs
…-docs adding root reminder
…nesis-ledger-for-hard-fork [berkeley] Update mainnet genesis ledger
Merge master to berkeley
[No-op] Merge compatible to berkeley
mrmr1993
requested review from
a team,
bkase,
mrmr1993,
nholland94 and
psteckler
as code owners
|
!ci-build-me |
|
!approved-for-mainnet |
dkijania
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Welcome 👋
Thank you for contributing to Mina! Please see
CONTRIBUTING.mdif you haven'tyet. In that doc, there are more details around how to start our CI.
If you cannot complete any of the steps below, please ask for help from a core
contributor.
Incomplete Work
We feel it's important that everyone is comfortable landing incomplete projects
so we don't keep PRs open for too long (especially on develop). To do this we
don't want to forget that something is incomplete, don't want to be blocked on
landing things, and we don't want to land anything that breaks the daemon. We
don't want to forget to test the incomplete things whenever they are completed,
and finally we want to clean up after ourselves: any temporary cruft gets
completely removed before a project is considered done.
To achieve the above, we wish to keep track of incomplete work using a draft of
the release notes. We can share this part of the current draft at anytime with
external contributors. Moreover, we will review this draft during hardforks.
To ship incomplete work, put it behind feature flags -- prefer a runtime
CLI/daemon-config-style flag if possible, and only if necessary fallthrough to
compile time flags. Note that if you put code behind a compile time flag, you
must ensure that CI is building all possible code paths. Don't land something
that doesn't build in CI.
PLEASE DELETE EVERYTHING ABOVE THIS LINE
Explain your changes:
*
Explain how you tested your changes:
*
Checklist: