BREAKING: Token detection V2 #763
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on to handle batch ignore, batch add, and mix batch add/ignore
…Clean up TokenDetectionController logic
NiranjanaBinoy
force-pushed
the
feature/3157-token-detection-v2-controllers
branch
from
067a76f
to
969ba69
Compare
| @@ -77,7 +77,7 @@ export class PreferencesController extends BaseController< | |||
| ipfsGateway: 'https://ipfs.io/ipfs/', | |||
| lostIdentities: {}, | |||
| selectedAddress: '', | |||
| useStaticTokenList: false, | |||
| useTokenDetection: false, | |||
There was a problem hiding this comment.
@Cal-L useStaticTokenList used to depict that we are using the static token list instead of the dynamic token list since we have changed the name and the purpose of the flag I feel like the useTokenDetection value as true will make it less confusing for the condition token detection ON by default. Would like to hear your thoughts on the same!?
…eature/3157-token-detection-v2-controllers
This was referenced Apr 27, 2022
Merged
[Token Detection V2] 2 of 7 - Add enum and util to check for supported token detection networks
#811
Merged
|
Closing in favor of #808 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introduce detected tokens state in addition to existing states, added and ignored
Support token detection on Mainnet, BSC, Polygon, and Avalanche
Remove use of tokens from contract-metadata AKA static tokens
BREAKING:
onNetworkChangeto constructor for updatingchainIdin controller's configaddTokenstoimportTokens. AddedignoreTokensto batch ignore detected tokens. AddedaddDetectedTokensto add detected tokens fromTokenDetectionController.useStaticTokenListandonPreferencesStateChangefrom constructor. Removed static token list from under the hood. Format token images to use Codefi's proxy. Exposeaggregatorsproperty on token object.onTokenListStateChangeto constructor to trigger token detection action whenever token list has changed.useStaticTokenListtouseTokenDetectionin constructor.isTokenDetectionEnabledForNetworkhelper function that takes achainIdand returns a boolean.Checklist
References
Notion - https://www.notion.so/Improve-token-detection-support-custom-networks-aka-TDF-v2-fb3ef7b7299c4ddb8e9481c2b22f1e87
Figma - https://www.figma.com/file/2h15YfvbT2q4q1FOMJFPP1/Token-Detection-V2?node-id=0%3A1