[Token Detection V2] Refining the polling interval and the occurrences limit for the Dynamic token list #836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cal-L
previously approved these changes
May 19, 2022
…okenlist-optimization
Merged
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
…s limit for the Dynamic token list (#836)
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
…s limit for the Dynamic token list (#836)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a part of #763
Based on the recent conversation with the core team, a proposal was made to update the
polling interval for the token list api to 24 hrsrather than the current 1 hour and we are also updating theoccurrences limit to 3, ie the dynamic list will contain only those tokens that will be present in at least 3 lists/aggregators.Related Notion doc:
https://www.notion.so/Improve-token-detection-support-custom-networks-aka-TDF-v2-fb3ef7b7299c4ddb8e9481c2b22f1e87#af9a0a475d024c5d8e8ada65cf9e764f