Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Token Detection V2] 1 of 7 - Throw on failure for fetchTokenMetadata in token service #812

Merged
merged 3 commits into from
May 5, 2022
Merged

[Token Detection V2] 1 of 7 - Throw on failure for fetchTokenMetadata in token service #812

merged 3 commits into from
May 5, 2022

Conversation

Cal-L
Copy link
Contributor

@Cal-L Cal-L commented Apr 27, 2022 •
edited
Loading

Throw on failure for fetchTokenMetadata in token service
1 of 7 PRs for #763

@Cal-L Cal-L requested a review from a team as a code owner April 27, 2022 23:11
@Cal-L Cal-L changed the title [Token Detection V2] Throw on failure for fetchTokenMetadata in token service [Token Detection V2] 1 of 7 - Throw on failure for fetchTokenMetadata in token service Apr 27, 2022
@Cal-L Cal-L mentioned this pull request Apr 27, 2022
Closed
2 tasks
@Cal-L Cal-L merged commit d4030cf into main May 5, 2022
@Cal-L Cal-L deleted the token-detection/type-token-fetch branch May 5, 2022 16:52
adonesky1 added a commit that referenced this pull request May 11, 2022
@adonesky1
Revert "[Token Detection V2] 1 of 7 - Throw on failure for fetchToken…
9b3be92 
…Metadata in token service (#812)"

This reverts commit d4030cf.
adonesky1 added a commit that referenced this pull request May 11, 2022
@adonesky1
Revert "[Token Detection V2] 1 of 7 - Throw on failure for fetchToken…
a25d909 
…Metadata in token service (#812)" (#824)

This reverts commit d4030cf.
Gudahtt added a commit that referenced this pull request May 12, 2022
@Gudahtt
Revert "Revert "[Token Detection V2] 1 of 7 - Throw on failure for fe…
2063d9b 
…tchTokenMetadata in token service (#812)" (#824)"

This reverts commit a25d909. It was
temporarily reverted to avoid making a breaking change in v29.0.1.
@Gudahtt Gudahtt mentioned this pull request May 12, 2022
Merged
Gudahtt added a commit that referenced this pull request May 12, 2022
@Gudahtt
Revert "Revert "[Token Detection V2] 1 of 7 - Throw on failure for fe…
865116c 
…tchTokenMetadata in token service (#812)" (#824)" (#827)

This reverts commit a25d909. It was
temporarily reverted to avoid making a breaking change in v29.0.1.
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
@Cal-L @MajorLift
[Token Detection V2] 1 of 7 - Throw on failure for fetchTokenMetadata…
25bc8dc 
… in token service (#812)

* Add type to fetchTokenMetadata and throw on failure.

* Define fetch token metadata error with const
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
@adonesky1 @MajorLift
Revert "[Token Detection V2] 1 of 7 - Throw on failure for fetchToken…
1d9fe9d 
…Metadata in token service (#812)" (#824)

This reverts commit d4030cf.
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
@Gudahtt @MajorLift
Revert "Revert "[Token Detection V2] 1 of 7 - Throw on failure for fe…
33c2550 
…tchTokenMetadata in token service (#812)" (#824)" (#827)

This reverts commit a25d909. It was
temporarily reverted to avoid making a breaking change in v29.0.1.
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
@Cal-L @MajorLift
[Token Detection V2] 1 of 7 - Throw on failure for fetchTokenMetadata…
36457b1 
… in token service (#812)

* Add type to fetchTokenMetadata and throw on failure.

* Define fetch token metadata error with const
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
@adonesky1 @MajorLift
Revert "[Token Detection V2] 1 of 7 - Throw on failure for fetchToken…
1d0922e 
…Metadata in token service (#812)" (#824)

This reverts commit d4030cf.
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
@Gudahtt @MajorLift
Revert "Revert "[Token Detection V2] 1 of 7 - Throw on failure for fe…
eca4f80 
…tchTokenMetadata in token service (#812)" (#824)" (#827)

This reverts commit a25d909. It was
temporarily reverted to avoid making a breaking change in v29.0.1.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NiranjanaBinoy NiranjanaBinoy NiranjanaBinoy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Cal-L @NiranjanaBinoy