Release 254.0.0 #4956
Release 254.0.0 #4956
Conversation
|
|
||
| ### Changed | ||
|
|
||
| - Bump `@metamask/keyring-api` from `^8.1.3` to `^10.1.0` ([#4948](https://github.com/MetaMask/core/pull/4948)) |
There was a problem hiding this comment.
@metamask/keyring-api v10 ships with a @metamask/providers (peer dependency) major version update that consumers of this package will have to update to, to avoid things breaking. I think this should be a major release for keyring-controller as well - what do you think?
There was a problem hiding this comment.
I think you are right yes... I did some digging yesterday about this, and the versions seem ok using yarn why, see:
However, I still think we should have bump the direct dependencies to snaps-* in the keyring-api to "align" the minimum dependency on @metamask/providers...
There was a problem hiding this comment.
I will re-release all packages and update the changelogs accordingly. I'm on it now.
There was a problem hiding this comment.
Posted in another comment but is this right? The See other thread. We can resolve this conversation.@metamask/providers peer dependency tells me that the thing that depends on @metamask/keyring-api should also depend on @metamask/providers, not the client. Or am I understanding this wrong?
ccharly
dismissed stale reviews from matthewwalsh0, gantunesr, and zone-live
via
9b2827c
|
Removed dependencies detected. Learn more about Socket for GitHub ↗︎ 🚮 Removed packages: npm/@metamask/[email protected], npm/@metamask/[email protected], npm/@metamask/[email protected], npm/@metamask/[email protected], npm/@metamask/[email protected] |
Co-authored-by: Elliot Winkler <[email protected]>
…o `^9.7.0` (#4959) ## Explanation This change was not required, and bumping peer dependency does require the "consumer" of that packages to potentially update his packages too, which would result in a breaking change for the `accounts-controller` here. ## References - #4956 (comment) ## Changelog N/A (since we would revert to the state of the last release of the `accounts-controller` for that specific line). ## Checklist - [ ] I've updated the test suite for new or updated code as appropriate - [ ] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [ ] I've highlighted breaking changes using the "BREAKING" category above as appropriate - [ ] I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes
Co-authored-by: Elliot Winkler <[email protected]>
Co-authored-by: Elliot Winkler <[email protected]>
…1` (#28545) ## **Description** Updating the `keyring-api` and Snap keyring alongside other controllers that depend on those versions too. Some controllers from [this release](MetaMask/core#4956) were left out from this PR mainly because the current major version being used in the extension is not updated yet. The current included controllers do have a peer dependency to either the `keyring-controller` or the `accounts-controller` which is why they are being included in this PR. [](https://codespaces.new/MetaMask/metamask-extension/pull/28545?quickstart=1) ## **Related issues** - MetaMask/core#4956 ## **Manual testing steps** N/A ## **Screenshots/Recordings** ### **Before** ### **After** ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
](https://codespaces.new/MetaMask/metamask-extension/pull/28545?quickstart=1){kind=link}
Major release for accounts-related packages (mostly due to peer dependency updates).
Mostly to align versions of the
keyring-apito enable Solana support in the extension.Related PR