Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: downgrade snaps-controllers peer dependency from ^9.10.0 to ^9.7.0 #4959

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

ccharly
Copy link
Contributor

@ccharly ccharly commented Nov 21, 2024

Explanation

This change was not required, and bumping peer dependency does require the "consumer" of that packages to potentially update his packages too, which would result in a breaking change for the accounts-controller here.

References

Changelog

N/A (since we would revert to the state of the last release of the accounts-controller for that specific line).

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@ccharly ccharly changed the title chore: downgrade snaps-controllers from ^9.10.0 to ^9.7.0 chore: downgrade snaps-controllers peer dependency from ^9.10.0 to ^9.7.0 Nov 21, 2024
@ccharly ccharly self-assigned this Nov 21, 2024
This change was not required, and bumping peer dependency does require
the "consumer" of that packages to potentially update his packages too,
which would result in a breaking change for the `accounts-controller`
here.
@ccharly ccharly force-pushed the chore/downgrade-snaps-controllers-peer-dep branch from 6e5b79d to 9f5788d Compare November 21, 2024 17:14
@ccharly ccharly mentioned this pull request Nov 21, 2024
@ccharly ccharly marked this pull request as ready for review November 21, 2024 17:14
@ccharly ccharly requested review from a team as code owners November 21, 2024 17:14
Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense! Thank you.

@ccharly ccharly merged commit 954e4b7 into main Nov 21, 2024
123 checks passed
@ccharly ccharly deleted the chore/downgrade-snaps-controllers-peer-dep branch November 21, 2024 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants