Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump keyring-api to ^10.1.0 + eth-snap-keyring to ^5.0.1 #28545

Merged
merged 8 commits into from
Nov 22, 2024

Conversation

ccharly
Copy link
Contributor

@ccharly ccharly commented Nov 19, 2024

Description

Updating the keyring-api and Snap keyring alongside other controllers that depend on those versions too.

Some controllers from this release were left out from this PR mainly because the current major version being used in the extension is not updated yet.

The current included controllers do have a peer dependency to either the keyring-controller or the accounts-controller which is why they are being included in this PR.

Open in GitHub Codespaces

Related issues

Manual testing steps

N/A

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@ccharly ccharly self-assigned this Nov 19, 2024
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@ccharly ccharly changed the title chore: bump keyring-api to ^9.0.0 + eth-snap-keyring to ^5.0.1 chore: bump keyring-api to ^10.1.0 + eth-snap-keyring to ^5.0.1 Nov 20, 2024
@ccharly ccharly force-pushed the chore/update-accounts-packages branch from d0ccb76 to 8401814 Compare November 22, 2024 10:59
@metamaskbot
Copy link
Collaborator

Builds ready [e9da8e3]
Page Load Metrics (2072 ± 106 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint172024902070217104
domContentLoaded170124812048216104
load171525132072222106
domInteractive15103502512
backgroundConnect10115322713
firstReactRender534721538139
getState686192110
initialActions01000
loadScripts12181875148618690
setupStore75616178
uiStartup193933352379315151
Bundle size diffs [🚀 Bundle size reduced!]
  • background: -19.8 KiB (-0.33%)
  • ui: 0 Bytes (0.00%)
  • common: 1.82 KiB (0.02%)

@ccharly ccharly marked this pull request as ready for review November 22, 2024 13:36
@ccharly ccharly requested review from a team as code owners November 22, 2024 13:36
Copy link
Contributor

@Prithpal-Sooriya Prithpal-Sooriya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for notifications and identity teams

@ccharly ccharly added this pull request to the merge queue Nov 22, 2024
Merged via the queue into develop with commit 4afb3bc Nov 22, 2024
81 checks passed
@ccharly ccharly deleted the chore/update-accounts-packages branch November 22, 2024 17:51
@github-actions github-actions bot locked and limited conversation to collaborators Nov 22, 2024
@metamaskbot metamaskbot added the release-12.9.0 Issue or pull request that will be included in release 12.9.0 label Nov 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.9.0 Issue or pull request that will be included in release 12.9.0 team-accounts
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

6 participants