-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump keyring-api
to ^10.1.0
+ eth-snap-keyring
to ^5.0.1
#28545
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@metamask/[email protected], npm/@metamask/[email protected], npm/@metamask/[email protected], npm/@metamask/[email protected], npm/[email protected] |
keyring-api
to ^9.0.0
+ eth-snap-keyring
to ^5.0.1
keyring-api
to ^10.1.0
+ eth-snap-keyring
to ^5.0.1
d0ccb76
to
8401814
Compare
Builds ready [e9da8e3]
Page Load Metrics (2072 ± 106 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for notifications and identity teams
Description
Updating the
keyring-api
and Snap keyring alongside other controllers that depend on those versions too.Some controllers from this release were left out from this PR mainly because the current major version being used in the extension is not updated yet.
The current included controllers do have a peer dependency to either the
keyring-controller
or theaccounts-controller
which is why they are being included in this PR.Related issues
Manual testing steps
N/A
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist