Bugfix2.0 "more" menu for lvglui interface#20939
Closed
Malderin wants to merge 763 commits intoMarlinFirmware:2.0.xfrom
Closed
Bugfix2.0 "more" menu for lvglui interface#20939Malderin wants to merge 763 commits intoMarlinFirmware:2.0.xfrom
Malderin wants to merge 763 commits intoMarlinFirmware:2.0.xfrom
Conversation
Co-authored-by: Scott Lahteine <github@thinkyhead.com>
Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com>
Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com>
Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com>
Co-authored-by: Scott Lahteine <github@thinkyhead.com>
Co-authored-by: Scott Lahteine <github@thinkyhead.com>
Member
|
I don’t think this PR will work this way. Where this code came from? From MKS? |
Contributor
Author
The code in draw_more.cpp is already present in the main code of marlin bugfix 2.0. |
Member
|
Try recreate the PR from bugfix. The branch you used as base is totally out of the shape. For example: you can create a new branch from bugfix and copy the code to make more menu working to this new branch. It will a lot less work, than fixing all those conflicts. The current state of this branch is a dead end. |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added "more" menu when using the interface from MKS LVGL (#define TFT_LVGL_UI in configuration.h). The menu is activated by the #define CUSTOM_USER_MENUS parameter in configuration_adv.h It is possible to add up to 7 custom commands.
Tested on MKS Robin nano v.2 with mks tft 35.