Reduce serial hook binary footprint.#20911
Merged
thinkyhead merged 1 commit intoMarlinFirmware:bugfix-2.0.xfrom Jan 29, 2021
Merged
Reduce serial hook binary footprint.#20911thinkyhead merged 1 commit intoMarlinFirmware:bugfix-2.0.xfrom
thinkyhead merged 1 commit intoMarlinFirmware:bugfix-2.0.xfrom
Conversation
Fix RuntimeHook connected loop
Member
|
I agree that optimizing to code for size is much more valuable than optimizing for some miniscule performance gain in an area that's not a performance bottleneck (such as serial output). |
X-Ryl669
added a commit
to X-Ryl669/MarlinForMKS
that referenced
this pull request
Jan 31, 2021
Jyers
pushed a commit
to Jyers/Marlin
that referenced
this pull request
Feb 3, 2021
kpishere
pushed a commit
to kpishere/Marlin
that referenced
this pull request
Feb 19, 2021
zillarob
pushed a commit
to zillarob/Marlin
that referenced
this pull request
Feb 25, 2021
W4tel-BiDi
pushed a commit
to W4tel-BiDi/Marlin
that referenced
this pull request
Apr 5, 2021
thinkyhead
pushed a commit
to thinkyhead/Marlin
that referenced
this pull request
Apr 29, 2021
thinkyhead
pushed a commit
that referenced
this pull request
Apr 30, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Reduce the binary size of my serial hooking code, as spotted by @thinkyhead .
Without this PR, I had:
After the PR, I now have:
It also fix RuntimeHook connected call loop
Requirements
None
Benefits
Reduce binary flash size by 4.2kB on my system at the cost of a bit less inlining of the serial code's print and write functions.
Configurations
None
Related Issues
PR #20783 last comment from Scott.