Add embedded terraform UI changes

[GilbertCherrie]

These are the UI changes necessary for this PR: ManageIQ/manageiq-providers-embedded_terraform#3

Added the credentials and repository forms for embedded terraform. Also made some other minor changes.

Repository Form:

Credential Form:

[jeffibm]

Hey, are there any screenshots for this?

[GilbertCherrie]

I added the screenshots of the add forms

[Fryguy]

Can any of this live in the new plugin? I see some changes are modifying existing controllers, so not those, but what about the new components?

[agrare]

@GilbertCherrie I know we discussed on slack but can you put the reason why you think the js components should live in this repo?

[GilbertCherrie]

@agrare By having the JS components in this repo it allows us to keep the same design pattern of defining the JS components and then calling them from the HAML files. This is technically possible to do all in the terraform repo but we would have to move over all the JS code required to load the JS components in the HAML files as well. Another option which we don't really use in the UI repo but exists in some of the provider repos is to call the JS files directly from the ruby button clicks.

[miq-bot]

Checked commit GilbertCherrie@46048c1 with ruby 2.7.8, rubocop 1.56.3, haml-lint 0.51.0, and yamllint
3 files checked, 0 offenses detected
Everything looks fine. 🍰

[jeffibm]

Hey @GilbertCherrie , the UI code looks solid.

but, I checked-out the branches and I don't see a menu item for Embedded Terraforms.

I was looking for changes in the default_menu.rb. and its corresponding changes in manageiq repo.

Am I missing anything else?

[agrare]

Hey @jeffibm do you have the latest embedded_terraform plugin?

[jeffibm]

Hey @jeffibm do you have the latest embedded_terraform plugin?

Hi @agrare , all I did was pull manageiq and execute bin/update. I didn't see a reference for embedded_terraform in manageiq.

[agrare]

@jeffibm the embedded_terraform plugin isn't in the core Gemfile yet so you have to have a ensure_gem directive to add it

[GilbertCherrie]

@jeffibm Yeah you have to overide the gem locally in the core repo like with running other providers/api repos locally:

ensure_gem "manageiq-providers-embedded_terraform", :path => "/Users/gilbertcherrie/manageiq-providers-embedded_terraform"

[jrafanie]

@GilbertCherrie I'm not sure if it's this PR or ManageIQ/manageiq-providers-embedded_terraform#3 but when I refresh a repository, it's missing a template for the refresh button and ultimately does nothing...

[----] I, [2024-04-25T10:55:49.151479#32533:f078]  INFO -- : Started POST "/embedded_terraform_repository/button?pressed=embedded_configuration_script_source_refresh" for ::1 at 2024-04-25 10:55:49 -0400
[----] I, [2024-04-25T10:55:49.276765#32533:f078]  INFO -- : Processing by EmbeddedTerraformRepositoryController#button as JS
[----] I, [2024-04-25T10:55:49.276858#32533:f078]  INFO -- :   Parameters: {"miq_grid_checks"=>"34", "pressed"=>"embedded_configuration_script_source_refresh"}
[----] D, [2024-04-25T10:55:49.314151#32533:f078] DEBUG -- : PostgreSQLAdapter#log_after_checkout, connection_pool: size: 15, connections: 1, in use: 1, waiting_in_queue: 0
[----] D, [2024-04-25T10:55:49.316310#32533:f078] DEBUG -- :   User Load (1.0ms)  SELECT "users".* FROM "users" WHERE "users"."id" BETWEEN $1 AND $2 AND "users"."userid" = $3 LIMIT $4  [["id", 0], ["id", 999999999999], ["userid", "admin"], ["LIMIT", 1]]
[----] D, [2024-04-25T10:55:49.316635#32533:f078] DEBUG -- :   User Inst Including Associations (0.2ms - 1rows)
[----] D, [2024-04-25T10:55:49.318135#32533:f078] DEBUG -- :   MiqGroup Load (0.7ms)  SELECT "miq_groups".* FROM "miq_groups" WHERE "miq_groups"."id" = $1 LIMIT $2  [["id", 2], ["LIMIT", 1]]
[----] D, [2024-04-25T10:55:49.318282#32533:f078] DEBUG -- :   MiqGroup Inst Including Associations (0.0ms - 1rows)
[----] D, [2024-04-25T10:55:49.319605#32533:f078] DEBUG -- :   Tenant Load (0.9ms)  SELECT "tenants".* FROM "tenants" WHERE "tenants"."id" = $1 LIMIT $2  [["id", 1], ["LIMIT", 1]]
[----] D, [2024-04-25T10:55:49.319786#32533:f078] DEBUG -- :   Tenant Inst Including Associations (0.1ms - 1rows)
[----] D, [2024-04-25T10:55:49.323043#32533:f078] DEBUG -- :   MiqUserRole Load (1.5ms)  SELECT "miq_user_roles".* FROM "miq_user_roles" INNER JOIN "entitlements" ON "miq_user_roles"."id" = "entitlements"."miq_user_role_id" WHERE "entitlements"."miq_group_id" = $1 LIMIT $2  [["miq_group_id", 2], ["LIMIT", 1]]
[----] D, [2024-04-25T10:55:49.323339#32533:f078] DEBUG -- :   MiqUserRole Inst Including Associations (0.1ms - 1rows)
[----] D, [2024-04-25T10:55:49.325568#32533:f078] DEBUG -- :    (1.4ms)  SELECT "miq_product_features"."identifier" FROM "miq_product_features" INNER JOIN "miq_roles_features" ON "miq_product_features"."id" = "miq_roles_features"."miq_product_feature_id" WHERE "miq_roles_features"."miq_user_role_id" = $1  [["miq_user_role_id", 1]]
[----] I, [2024-04-25T10:55:49.326283#32533:f078]  INFO -- : No template found for EmbeddedTerraformRepositoryController#button, rendering head :no_content

I have to edit the repository name/desc to save it and have it refresh the repository since the button doesn't work.

I'm running with gem overrides for #9117 and a branch of the plugin with both ManageIQ/manageiq-providers-embedded_terraform#12 and ManageIQ/manageiq-providers-embedded_terraform#16 applied.

[GilbertCherrie]

Looks like it was broken in the plugin code, @jrafanie I fixed the issue in this pr: ManageIQ/manageiq-providers-embedded_terraform#17

[jeffibm]

@jeffibm Yeah you have to overide the gem locally in the core repo like with running other providers/api repos locally:

ensure_gem "manageiq-providers-embedded_terraform", :path => "/Users/gilbertcherrie/manageiq-providers-embedded_terraform"

Hey @agrare , @GilbertCherrie , I can see the menu items and forms now..