Add EmbeddedTerraform Stack and Job #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
40 tasks
agrare
force-pushed
the
add_orchestration_stack_and_job
branch
4 times, most recently
from
69b1828 to
12d1b54
Compare
agrare
changed the title
agrare
force-pushed
the
add_orchestration_stack_and_job
branch
2 times, most recently
from
e87c25a to
c1b4713
Compare
agrare
changed the title
agrare
force-pushed
the
add_orchestration_stack_and_job
branch
from
c1b4713 to
8dcd5f0
Compare
Member
Author
|
Okay @jrafanie this is ready for review |
jrafanie
reviewed
Apr 25, 2024
| end | ||
|
|
||
| def poll_interval | ||
| options.fetch(:poll_interval, 1.minute).to_i |
Member
There was a problem hiding this comment.
1 minute seems like a long time. How long are we expecting short and long templates to take to run? Would 30 seconds be better?
jrafanie
approved these changes
Apr 25, 2024
Member
jrafanie
left a comment
jrafanie
left a comment
There was a problem hiding this comment.
Looks good to me, we can change that poll interval in a followup.
Member
|
@putmanoj I think this reworks some of the POC code you had around workflows, I'm merging today. Let me know if you need help getting your workflows branch working with this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
EmbeddedTerraform::AutomationManager::Stackwhich is anOrchestrationStacksubclassAdds
EmbeddedTerraform::AutomationManager::Template#runwhich is called byEmbeddedTerraform::AutomationManager::Stack.create_stackand creates&starts aJobstate-machineAdds
EmbeddedTerraform::AutomationManager::Jobwhich is a::Jobstate-machine and is responsible for running and polling for completion any terraform runner tasks.