Rename ansible product features to renamed generic terms #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These features are being renamed in: ManageIQ/manageiq#22971
This was referenced May 2, 2024
Merged
Merged
jrafanie
commented
May 2, 2024
| Menu::Section.new(:embedded_terraform_automation_manager, N_("Embedded Terraform"), nil, [ | ||
| Menu::Item.new('embedded_terraform_template', N_('Templates'), 'embedded_terraform_template', {:feature => 'embedded_configuration_script_payload_view', :any => true}, '/embedded_terraform_template/show_list'), | ||
| Menu::Item.new('embedded_terraform_repository', N_('Repositories'), 'embedded_terraform_repository', {:feature => 'embedded_configuration_script_source_view', :any => true}, '/embedded_terraform_repository/show_list'), | ||
| Menu::Item.new('embedded_terraform_credentials', N_('Credentials'), 'embedded_terraform_credentials', {:feature => 'embedded_configuration_script_source_view', :any => true}, '/embedded_terraform_credential/show_list') |
Member
Author
There was a problem hiding this comment.
This fixes the menu sections to reuse the existing shared product feature. This means that if you enable either embedded ansible or embedded terraform features, they are shared so, the check box for one will be enable it for the other.
For example, I enabled just configuration scripts in embedded ansible and it enables it for embedded terraform after saving and reloading the page.
jrafanie
force-pushed
the
rename_ansible_tag_features_to_be_generic
branch
from
a9fe645 to
545883b
Compare
jrafanie
force-pushed
the
rename_ansible_tag_features_to_be_generic
branch
from
545883b to
be3b8be
Compare
Member
|
Checked commits jrafanie/manageiq-providers-embedded_terraform@be4ee03~...be3b8be with ruby 2.7.8, rubocop 1.56.3, haml-lint 0.51.0, and yamllint |
agrare
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: ManageIQ/manageiq#22971
Merge together: