Add the two new critical passages and one "critical land blockage" #103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
Collaborator
Author
|
Andrew approved the depths (250 for Nares, 50 for White) but I'm open to changes. |
xylar
force-pushed
the
add_nares_strait_white_sea_antarctic_pen
branch
from
59bbfd9 to
60af685
Compare
mark-petersen
added a commit
to MPAS-Dev/MPAS-Model
that referenced
this pull request
Mar 6, 2019
…elop Add critical land blockages to global_ocean tests Adds support for transects that must be land to the new global ocean setup in COMPASS These changes will only work along with: MPAS-Dev/geometric_features#103 and MPAS-Dev/MPAS-Tools#247
mark-petersen
approved these changes
Mar 6, 2019
Collaborator
mark-petersen
left a comment
mark-petersen
left a comment
There was a problem hiding this comment.
See testing of this PR, and review at MPAS-Dev/MPAS-Model#169 (comment). It all works.
We may need to adjust the details of these critical passages in the next month, but the overall process works and so I am merging. Further adjustments will be with a new PR.
mark-petersen
added a commit
that referenced
this pull request
Mar 6, 2019
These features are needed for the CONUS grid in E3SM and perhaps for future versions of our EC60to30 and similar lower resolution meshes.
ashwathsv
pushed a commit
to ashwathsv/MPAS-Model
that referenced
this pull request
Jul 21, 2020
…cean/develop Add critical land blockages to global_ocean tests Adds support for transects that must be land to the new global ocean setup in COMPASS These changes will only work along with: MPAS-Dev/geometric_features#103 and MPAS-Dev/MPAS-Tools#247
xylar
pushed a commit
to xylar/old_compass2
that referenced
this pull request
Oct 12, 2020
…elop Add critical land blockages to global_ocean tests Adds support for transects that must be land to the new global ocean setup in COMPASS These changes will only work along with: MPAS-Dev/geometric_features#103 and MPAS-Dev/MPAS-Tools#247
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These features are needed for the CONUS grid in E3SM and perhaps for future versions of our EC60to30 and similar lower resolution meshes.