Skip to content

Conversation

@xylar
Copy link
Collaborator

@xylar xylar commented Feb 28, 2019

These are transects that must be land cells, the opposite of critical passages (transects that must be ocean).

These are transects that must be land cells, the opposite of
critical passages (transects that must be ocean).
@xylar xylar self-assigned this Feb 28, 2019
@xylar xylar requested a review from mark-petersen February 28, 2019 02:24
mark-petersen added a commit to MPAS-Dev/MPAS-Model that referenced this pull request Mar 6, 2019
…elop

Add critical land blockages to global_ocean tests
Adds support for transects that must be land to the new global ocean
setup in COMPASS

These changes will only work along with:
MPAS-Dev/geometric_features#103
and
MPAS-Dev/MPAS-Tools#247
Copy link
Collaborator

@mark-petersen mark-petersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See testing of this PR, and review at MPAS-Dev/MPAS-Model#169 (comment). It all works.

@mark-petersen mark-petersen merged commit 4916a9e into MPAS-Dev:master Mar 6, 2019
mark-petersen added a commit that referenced this pull request Mar 6, 2019
Add a script to mark critical land blockages.
These are transects that must be land cells, the opposite of critical
passages (transects that must be ocean).
@xylar xylar deleted the ocean/add_critical_land_blockage branch March 7, 2019 03:09
ashwathsv pushed a commit to ashwathsv/MPAS-Model that referenced this pull request Jul 21, 2020
…cean/develop

Add critical land blockages to global_ocean tests
Adds support for transects that must be land to the new global ocean
setup in COMPASS

These changes will only work along with:
MPAS-Dev/geometric_features#103
and
MPAS-Dev/MPAS-Tools#247
xylar pushed a commit to xylar/old_compass2 that referenced this pull request Oct 12, 2020
…elop

Add critical land blockages to global_ocean tests
Adds support for transects that must be land to the new global ocean
setup in COMPASS

These changes will only work along with:
MPAS-Dev/geometric_features#103
and
MPAS-Dev/MPAS-Tools#247
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants