-
Notifications
You must be signed in to change notification settings - Fork 385
Add critical land blockages to global_ocean tests #169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add critical land blockages to global_ocean tests #169
Conversation
|
These changes will only work along with: |
TestingSo far, I have only tested on a QU240 mesh and that's a bit of a hacky test because I don't have Jigsaw yet so I just copied the mesh for a global_ocean_V1 test case. Here is the masking I see: At this resolution, it's pretty hideous but the land mask has been thickened a bit around the Peninsula (unnecessarily in this case) to make sure there's no through-flow. |
|
@mark-petersen, could you try this with the EC60to30 setup, since you're ready to do the full Jigsaw workflow? Then, we could try CONUS if that works. |
|
This is a mega-test, where I test multiple components at once for the EC60to30 mesh: I ran all the way through init and part of spin-up. Everything went through. On these images, we have left to right EC60to30 from
These images show that the new features work, or at least don't cause harm. Note that Nares Strait is open on upper left. Thank you @xylar for your dedicated effort on this. |
|
It's also very nice to look at the mask files, as they show what cells were removed or forced in, and why. Here is the file While this file shows the cells that are removed because otherwise sea ice can't flow through: |
|
If anyone wants to explore these files and make more plots, be my guest. Grab this tar file: or see the directory here: |
mark-petersen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The EC60to30 images were enough to convince me these four PRs are working together properly. If it turns out we need further refinement, it will go into another PR. Thanks again @xylar.
…elop Add critical land blockages to global_ocean tests Adds support for transects that must be land to the new global ocean setup in COMPASS These changes will only work along with: MPAS-Dev/geometric_features#103 and MPAS-Dev/MPAS-Tools#247
|
The screenshots in this PR should not be studied in too much detail, as the land mask is corrupted, see: #176 |
…cean/develop Add critical land blockages to global_ocean tests Adds support for transects that must be land to the new global ocean setup in COMPASS These changes will only work along with: MPAS-Dev/geometric_features#103 and MPAS-Dev/MPAS-Tools#247
…cean/develop Add critical land blockages to global_ocean tests Adds support for transects that must be land to the new global ocean setup in COMPASS These changes will only work along with: MPAS-Dev/geometric_features#103 and MPAS-Dev/MPAS-Tools#247
…FS-A (MPAS-Dev#169) * "To read smoke/dust intial and boundary conditions from RRFS-A" * "update following the reviewer's suggestions" * "check smoke/dust; remove references to MASSDEN and keep smoke_fine" * "initialize chemistry indexes to null()" * "update version number to 8.3.1-2.6" * "update the hash of SMOKE submodule to remove dust timing" * "update version to 8.3.1-noaa in the Registry.xml files"










Adds support for transects that must be land to the new global ocean setup in COMPASS