Skip to content

docs(archive): Maji PR preservation batch 20#4350

Merged
AceHack merged 2 commits into
mainfrom
lior-archive-prs-batch-20
May 19, 2026
Merged

docs(archive): Maji PR preservation batch 20#4350
AceHack merged 2 commits into
mainfrom
lior-archive-prs-batch-20

Conversation

@AceHack
Copy link
Copy Markdown
Member

@AceHack AceHack commented May 19, 2026

Automated preservation of recently merged PRs (4343, 4337, 4319, 4316, 4312) to docs/pr-discussions/ to capture memory and reasoning.

Copilot AI review requested due to automatic review settings May 19, 2026 07:00
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a1065d31ac

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a new PR-preservation batch under docs/pr-discussions/ to archive recently merged PRs (#4343, #4337, plus timestamp/format refresh for #4319/#4316/#4312), capturing metadata and selected review-thread content for later reference.

Changes:

  • Adds new PR-discussion archive records for PR #4343 and PR #4337.
  • Updates archived_at timestamps for existing preserved PRs (#4319, #4316, #4312).
  • Adjusts preserved content in PR #4316 (but introduces a Markdown rendering regression via a literal \n).

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
docs/pr-discussions/PR-4343-shard-0608z-otto-cli-session-arc-maji-response-canary-sharpe.md New archive record for PR #4343 (session shard write-up + preserved review thread).
docs/pr-discussions/PR-4337-docs-archive-maji-pr-preservation-batch-18.md New archive record for PR #4337 (prior preservation batch summary + preserved review note).
docs/pr-discussions/PR-4319-docs-shadow-maji-anti-entropy-shadow-report-on-otto-and-rive.md Refreshes archived_at metadata timestamp.
docs/pr-discussions/PR-4316-docs-shadow-maji-anti-entropy-shadow-report-on-riven-paralys.md Refreshes archived_at and modifies preserved PR description (currently malformed).
docs/pr-discussions/PR-4312-fix-hygiene-clear-2026-05-18-tick-link-drift.md Refreshes archived_at metadata timestamp.

Both Codex (P2) + Copilot (P1) flagged that line 19 contained a
literal '\\n' escape sequence in the archived PR description, so
the '## Maji Drift Report' heading and the body paragraph rendered
as a single physical line with raw text instead of as a heading
followed by a blank line and the paragraph.

Replace the escape with a real blank line so Markdown renders
correctly.

Co-Authored-By: Claude <noreply@anthropic.com>
@AceHack
Copy link
Copy Markdown
Member Author

AceHack commented May 19, 2026

Fixed in 524dd0b — replaced the literal `\n` in line 19 with a real blank line so the ## Maji Drift Report heading + paragraph render correctly. Both Codex P2 + Copilot P1 threads land on the same root cause; one commit resolves both. Arming auto-merge.

@AceHack AceHack enabled auto-merge (squash) May 19, 2026 07:10
@AceHack AceHack merged commit 9b2722f into main May 19, 2026
25 of 26 checks passed
@AceHack AceHack deleted the lior-archive-prs-batch-20 branch May 19, 2026 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants