Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Update Bolts link #6743

Merged
merged 3 commits into from
Mar 30, 2021
Merged

[docs] Update Bolts link #6743

merged 3 commits into from
Mar 30, 2021

Conversation

akihironitta
Copy link
Contributor

@akihironitta akihironitta commented Mar 30, 2021 •
edited
Loading

What does this PR do?

GitHub redirects the old link to the new one, so this PR only changes the broken link to the Bolts docs.
Old (404): https://pytorch-lightning-bolts.readthedocs.io
New: https://lightning-bolts.readthedocs.io

The related PR in Bolts is Lightning-Universe/lightning-bolts#583.

I checked the lines with

$ grep -rn pytorch-lightning-bolts . | grep -v github.com

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@akihironitta akihironitta added the docs Documentation related label Mar 30, 2021
@akihironitta akihironitta added this to the 1.2.x milestone Mar 30, 2021
@akihironitta akihironitta marked this pull request as ready for review March 30, 2021 13:42
tchaton
tchaton approved these changes Mar 30, 2021
View reviewed changes
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@Borda Borda enabled auto-merge (squash) March 30, 2021 14:19
@codecov
Copy link

codecov bot commented Mar 30, 2021

Codecov Report

Merging #6743 (fb9011f) into master (583fcf2) will decrease coverage by 5%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #6743    +/-   ##
=======================================
- Coverage      91%     87%    -5%     
=======================================
  Files         192     192            
  Lines       12174   12174            
=======================================
- Hits        11133   10584   -549     
- Misses       1041    1590   +549

@Borda Borda merged commit 9876df1 into master Mar 30, 2021
@Borda Borda deleted the docs/update-bolts-link branch March 30, 2021 17:23
@kaushikb11 kaushikb11 mentioned this pull request Apr 5, 2021
Closed
kaushikb11 pushed a commit to kaushikb11/pytorch-lightning that referenced this pull request Apr 6, 2021
@akihironitta @Borda @kaushikb11
[docs] Update Bolts link (Lightning-AI#6743)
34e7282 
* Update Bolts link

* Update Bolts link

* formt

Co-authored-by: Jirka Borovec <[email protected]>
lexierule pushed a commit that referenced this pull request Apr 7, 2021
@kaushikb11 @Borda
@tchaton @akihironitta @sailordiary @rohitgr7 @carmocca @elimohl @awaelchli @karthikprasad @sadiqj @mibaumgartner @BloodAxe @ethanwharris @THasthika
Weekly Patch Release v.1.2.7 [full merge, no squash] (#6850)
b2c7345 
* update readme by v1.2.x (#6728)

* [bugfix] Add support for omegaconf and tpu (#6741)

* fix_hydra

* update changelog

Co-authored-by: Your Name <[email protected]>

* [docs] Update Bolts link (#6743)

* Update Bolts link

* Update Bolts link

* formt

Co-authored-by: Jirka Borovec <[email protected]>

* Update logic for checking TPUs availability (#6767)

* Update logic for checking TPUs availability

* fix flake8

* add fix

* resolve bug (#6781)

* Fix validation progress counter with check_val_every_n_epoch > 1 (#5952)

Co-authored-by: rohitgr7 <[email protected]>
Co-authored-by: Carlos Mocholí <[email protected]>

* Remove extinct parameters from lightning_module.rst (#6801)

Fixes  #6800

* Update TPU docs for installation (#6794)

* fix boolean check on iterable dataset when len not defined (#6828)

* fix iterable dataset len check

* update predict and validate

* add validate to test

* add changelog

* add predict

* Sanitize `None` params during pruning (#6836)

* sanitize none params during pruning

* amend

* Fix `unfreeze_and_add_param_group` expects `modules` rather than `module` (#6822)

* Enforce an epoch scheduler interval when using SWA (#6588)

Co-authored-by: Carlos Mocholi <[email protected]>

* Fix DPP + SyncBN (#6838)

* Fix DPP + SyncBN

Ensure that model is already on correct GPU before applying SyncBN conversion

* Fix order of SyncBN for ddp_spawn

* [Fix] TPU Training Type Plugin (#6816)

* Fix support for symlink save_dir in TensorBoardLogger (#6730)

* Add test for symlink support and initial fix

* Respond to comment and add docstring

* Update CHANGELOG.md

* Simplify

* Update pytorch_lightning/utilities/cloud_io.py

Co-authored-by: Carlos Mocholí <[email protected]>

* Make `LightningLocalFileSystem` protected

Co-authored-by: Carlos Mocholí <[email protected]>

* Fixed missing arguments in `lr_find` call (#6784)

There seem to be 3 arguments missing in the `lr_find` call in the tunining.py file.

* Update Changelog & version

* Fix TPU tests for checkpoint

Skip advanced profiler for torch > 1.8

Skip pytorch profiler for torch > 1.8

Fix save checkpoint logic for TPUs

Co-authored-by: Jirka Borovec <[email protected]>
Co-authored-by: thomas chaton <[email protected]>
Co-authored-by: Your Name <[email protected]>
Co-authored-by: Akihiro Nitta <[email protected]>
Co-authored-by: Yuan-Hang Zhang <[email protected]>
Co-authored-by: rohitgr7 <[email protected]>
Co-authored-by: Carlos Mocholí <[email protected]>
Co-authored-by: Elizaveta Logacheva <[email protected]>
Co-authored-by: Adrian Wälchli <[email protected]>
Co-authored-by: Karthik Prasad <[email protected]>
Co-authored-by: Sadiq Jaffer <[email protected]>
Co-authored-by: Michael Baumgartner <[email protected]>
Co-authored-by: Eugene Khvedchenya <[email protected]>
Co-authored-by: Ethan Harris <[email protected]>
Co-authored-by: Tharindu Hasthika <[email protected]>
lexierule pushed a commit that referenced this pull request Apr 7, 2021
@akihironitta @Borda @lexierule
[docs] Update Bolts link (#6743)
523db14 
* Update Bolts link

* Update Bolts link

* formt

Co-authored-by: Jirka Borovec <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaushikb11 kaushikb11 kaushikb11 approved these changes

@tchaton tchaton tchaton approved these changes

@Borda Borda Borda approved these changes

@awaelchli awaelchli Awaiting requested review from awaelchli

@carmocca carmocca Awaiting requested review from carmocca

@edenlightning edenlightning Awaiting requested review from edenlightning

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

@williamFalcon williamFalcon Awaiting requested review from williamFalcon williamFalcon is a code owner

Assignees
No one assigned
Labels
docs Documentation related
Projects
None yet
Milestone
pl:1.2.x
Development

Successfully merging this pull request may close these issues.
4 participants
@akihironitta @Borda @tchaton @kaushikb11