Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: shorten bolts name #583

Merged
merged 5 commits into from
Mar 9, 2021
Merged

Refactor: shorten bolts name #583

merged 5 commits into from
Mar 9, 2021

Conversation

Borda
Copy link
Member

@Borda Borda commented Mar 9, 2021

What does this PR do?

make the name consistent with all other PL packages
needed after real rename:

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Mar 9, 2021
@codecov
Copy link

codecov bot commented Mar 9, 2021

Codecov Report

Merging #583 (d48580e) into master (79d4184) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #583      +/-   ##
==========================================
- Coverage   76.58%   76.54%   -0.05%     
==========================================
  Files         117      117              
  Lines        6850     6850              
==========================================
- Hits         5246     5243       -3     
- Misses       1604     1607       +3     
Flag Coverage Δ
cpu 26.20% <100.00%> (ø)
pytest 26.20% <100.00%> (ø)
unittests 76.02% <100.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pl_bolts/__init__.py 90.47% <100.00%> (ø)
...l_bolts/models/rl/vanilla_policy_gradient_model.py 92.79% <0.00%> (-2.71%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79d4184...4798267. Read the comment docs.

@Borda Borda marked this pull request as ready for review March 9, 2021 16:33
@Borda Borda requested a review from edenlightning as a code owner March 9, 2021 16:34
Copy link

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@Borda Borda merged commit 3de17c0 into master Mar 9, 2021
@Borda Borda deleted the refactor/bolts branch March 9, 2021 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion documentation Improvements or additions to documentation refactoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants