Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some properties of LightningModule were removed from the code, but left in the doc. #6800

Closed
elimohl opened this issue Apr 2, 2021 · 0 comments · Fixed by #6801
Closed
Labels
docs Documentation related

Comments

@elimohl
Copy link
Contributor

elimohl commented Apr 2, 2021

Properties use_dp, use_ddp, use_ddp2, use_tpu were removed at in #5300 but left in the documentation.

(Now we need to set the use_ddp parameter in our modules manually if we want to check whether the trainer uses DDP, am I right?)

@elimohl elimohl added the docs Documentation related label Apr 2, 2021
elimohl added a commit to elimohl/pytorch-lightning that referenced this issue Apr 2, 2021
kaushikb11 pushed a commit to kaushikb11/pytorch-lightning that referenced this issue Apr 6, 2021
lexierule pushed a commit that referenced this issue Apr 7, 2021
* update readme by v1.2.x (#6728)

* [bugfix] Add support for omegaconf and tpu (#6741)

* fix_hydra

* update changelog

Co-authored-by: Your Name <[email protected]>

* [docs] Update Bolts link (#6743)

* Update Bolts link

* Update Bolts link

* formt

Co-authored-by: Jirka Borovec <[email protected]>

* Update logic for checking TPUs availability (#6767)

* Update logic for checking TPUs availability

* fix flake8

* add fix

* resolve bug (#6781)

* Fix validation progress counter with check_val_every_n_epoch > 1 (#5952)

Co-authored-by: rohitgr7 <[email protected]>
Co-authored-by: Carlos Mocholí <[email protected]>

* Remove extinct parameters from lightning_module.rst (#6801)

Fixes  #6800

* Update TPU docs for installation (#6794)

* fix boolean check on iterable dataset when len not defined (#6828)

* fix iterable dataset len check

* update predict and validate

* add validate to test

* add changelog

* add predict

* Sanitize `None` params during pruning (#6836)

* sanitize none params during pruning

* amend

* Fix `unfreeze_and_add_param_group` expects `modules` rather than `module` (#6822)

* Enforce an epoch scheduler interval when using SWA (#6588)

Co-authored-by: Carlos Mocholi <[email protected]>

* Fix DPP + SyncBN (#6838)

* Fix DPP + SyncBN

Ensure that model is already on correct GPU before applying SyncBN conversion

* Fix order of SyncBN for ddp_spawn

* [Fix] TPU Training Type Plugin (#6816)

* Fix support for symlink save_dir in TensorBoardLogger (#6730)

* Add test for symlink support and initial fix

* Respond to comment and add docstring

* Update CHANGELOG.md

* Simplify

* Update pytorch_lightning/utilities/cloud_io.py

Co-authored-by: Carlos Mocholí <[email protected]>

* Make `LightningLocalFileSystem` protected

Co-authored-by: Carlos Mocholí <[email protected]>

* Fixed missing arguments in `lr_find` call (#6784)

There seem to be 3 arguments missing in the `lr_find` call in the tunining.py file.

* Update Changelog & version

* Fix TPU tests for checkpoint

Skip advanced profiler for torch > 1.8

Skip pytorch profiler for torch > 1.8

Fix save checkpoint logic for TPUs

Co-authored-by: Jirka Borovec <[email protected]>
Co-authored-by: thomas chaton <[email protected]>
Co-authored-by: Your Name <[email protected]>
Co-authored-by: Akihiro Nitta <[email protected]>
Co-authored-by: Yuan-Hang Zhang <[email protected]>
Co-authored-by: rohitgr7 <[email protected]>
Co-authored-by: Carlos Mocholí <[email protected]>
Co-authored-by: Elizaveta Logacheva <[email protected]>
Co-authored-by: Adrian Wälchli <[email protected]>
Co-authored-by: Karthik Prasad <[email protected]>
Co-authored-by: Sadiq Jaffer <[email protected]>
Co-authored-by: Michael Baumgartner <[email protected]>
Co-authored-by: Eugene Khvedchenya <[email protected]>
Co-authored-by: Ethan Harris <[email protected]>
Co-authored-by: Tharindu Hasthika <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation related
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant