-
Notifications
You must be signed in to change notification settings - Fork 652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Core: Remove CCharEntity::pushPacket(raw packet) #6713
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zach2good
force-pushed
the
remove_push_packet_raw
branch
6 times, most recently
from
January 14, 2025 15:24
4f95813
to
88d412e
Compare
4 tasks
zach2good
force-pushed
the
remove_push_packet_raw
branch
from
January 14, 2025 16:55
88d412e
to
6ea2f74
Compare
3 tasks
zach2good
force-pushed
the
remove_push_packet_raw
branch
from
January 14, 2025 18:39
c6c5c57
to
0c5c0fc
Compare
3 tasks
zach2good
force-pushed
the
remove_push_packet_raw
branch
from
January 15, 2025 10:42
f7d060b
to
d7b3bc4
Compare
zach2good
force-pushed
the
remove_push_packet_raw
branch
from
January 15, 2025 11:56
f8e58eb
to
80afa51
Compare
This is now very well tested and ready for review |
zach2good
force-pushed
the
remove_push_packet_raw
branch
from
January 15, 2025 12:42
e18f699
to
98ae9d1
Compare
Xaver-DaRed
approved these changes
Jan 15, 2025
3 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I affirm:
What does this pull request do?
Closes #6545
After looking here: I realised how easy it still is to leak packets: #6711
A big step towards: #5171
The scope of this blew up, as always. Now,
CBasicPacket
is ONLY a wrapper aroundstd::array<uint8, PACKET_SIZE> buffer_;
. It doesn't do non-owning, I've audited how they're constructed, etc. We also now NEVERnew
a packet - it's always constructed as aunique_ptr
, and we are careful to pass around references or move them as needed. This also means that we have to be obvious when we witherstd::move()
or->copy()
packets in places.But now, there's no question about what happens where - we can see what our data is doing.
Testing