Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔨 CBasicPacket's children shouldn't have member vars #6717

Open
3 tasks done
zach2good opened this issue Jan 14, 2025 · 1 comment
Open
3 tasks done

🔨 CBasicPacket's children shouldn't have member vars #6717

zach2good opened this issue Jan 14, 2025 · 1 comment
Labels
enhancement New feature request good first issue Good for newcomers

Comments

@zach2good
Copy link
Contributor

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my issue will be ignored.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have searched existing issues to see if the issue has already been opened, and I have checked the commit log to see if the issue has been resolved since my server was last updated.

Describe the feature

As just seen in #6713, packets should just be wrappers on top of CBasicPacket and only have constructors that write to the underlying buffer, and accessors that read that buffer in different ways.
@zach2good zach2good added enhancement New feature request good first issue Good for newcomers labels Jan 14, 2025
@zach2good
Copy link
Contributor Author

Relevant commit: 29f9534

@zach2good zach2good changed the title 🔨 Packets shouldn't have member vars 🔨 CBasicPacket's children shouldn't have member vars Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zach2good