🐛 ACTION MAGIC INTERRUPT -> Crashing

[GeneralLD]

I affirm:

• I understand that if I do not agree to the following points by completing the checkboxes my issue will be ignored.
• I have read and understood the Contributing Guide and the Code of Conduct.
• I have searched existing issues to see if the issue has already been opened, and I have checked the commit log to see if the issue has been resolved since my server was last updated.

OS / platform the server is running (if known)

Branch affected by issue

base

Steps to reproduce

Attached bug report in VS, Casting Aero to allow spell to complete with no issues, casting spell then interrupting spell with movement, casting spell again and move again to interrupt spell causing a crash.

Expected behavior

i still have crash report up so if you need additional information, let me know

[WinterSolstice8]

Seems like a null pointer somewhere, will check, thanks

[WinterSolstice8]

confirmed /w your repro steps

[WinterSolstice8]

Should folks play test their changes before live pull requests? How does it work here? Who decides when a pull request is needed, ready, etc.? Does anyone play test them? Just earnestly asking since I don't know.

They do. It's not possible to find every single corner case

[WinterSolstice8]

Just a reminder

server/LICENSE

Lines 44 to 45 in fa88c83

	For the developers' and authors' protection, the GPL clearly explains
	that there is no warranty for this free software. For both users' and

This is our hobby and we do our best, when massive rewrites happen because old garbage code needs to be fixed occasionally little things fall through the cracks.

It is of my opinion that this codebase is not and will not be ready for production for a long time, you are essentially using a permanent pre-release

Obviously we care about bugs, and I care that it's usable, but sometimes shit happens. All I can really offer is report stuff and we'll get to it when we can (obviously, I am prioritizing crashes over anything else)

[zach2good]

This came in because I changed every site where packets are created and moved around: #6713

You can see the testing steps I took. With large architectural changes like this it's essentially impossible to cover every corner case