availability and latency slos #596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david-martin
requested changes
May 3, 2024
Update the sloth-generate target to output PrometheusRules files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating SLO for both availability and latency using sloth.
##Verification
Unit tests
Run promtool tests:
make alerts-testsYou should see success for both alerts
Sloth generation
Install Sloth SLI https://sloth.dev/introduction/install/
Run
generate -i examples/alerts/sloth/latency.yaml --default-slo-period=28dThe generated yaml should match the current alert for latency and when you change the file to availability you should see the same.