Skip to content

Commit

Permalink
adding new line
Browse files Browse the repository at this point in the history
  • Loading branch information
R-Lawton committed May 3, 2024
1 parent b3ae647 commit 3cbe450
Show file tree
Hide file tree
Showing 7 changed files with 4 additions and 11 deletions.
1 change: 0 additions & 1 deletion examples/alerts/slo-availability.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -201,4 +201,3 @@ spec:
summary: High error rate on HTTPRoute requests responses
title: (ticket) {{$labels.sloth_service}} {{$labels.sloth_slo}} SLO error budget
burn rate is too fast.

2 changes: 1 addition & 1 deletion examples/alerts/slo-latency.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -201,4 +201,4 @@ spec:
summary: High latency on HTTPRoute requests responses
title: (ticket) {{$labels.sloth_service}} {{$labels.sloth_slo}} SLO error budget
burn rate is too fast.

Check failure on line 204 in examples/alerts/slo-latency.yaml

View workflow job for this annotation

GitHub Actions / Lint

[EOF Newline] reported by reviewdog 🐶 Missing newline Raw Output: examples/alerts/slo-latency.yaml:204: Missing newline
2 changes: 1 addition & 1 deletion examples/alerts/sloth/availability.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -23,4 +23,4 @@ slos:
ticket_alert:
labels:
severity: warning

1 change: 0 additions & 1 deletion examples/alerts/sloth/latency.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -27,4 +27,3 @@ slos:
ticket_alert:
labels:
severity: warning

2 changes: 1 addition & 1 deletion examples/alerts/tests/availability_test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -41,5 +41,5 @@ tests:
exp_annotations:
summary: High error rate on HTTPRoute requests responses
title: (ticket) kuadrant requests-availability SLO error budget burn rate is too fast.


Check failure on line 45 in examples/alerts/tests/availability_test.yaml

View workflow job for this annotation

GitHub Actions / Lint

[EOF Newline] reported by reviewdog 🐶 Missing newline Raw Output: examples/alerts/tests/availability_test.yaml:45: Missing newline
2 changes: 1 addition & 1 deletion examples/alerts/tests/latency_test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -41,4 +41,4 @@ tests:
exp_annotations:
summary: High latency on HTTPRoute requests responses
title: (ticket) kuadrant requests-latency SLO error budget burn rate is too fast.

Check failure on line 44 in examples/alerts/tests/latency_test.yaml

View workflow job for this annotation

GitHub Actions / Lint

[EOF Newline] reported by reviewdog 🐶 Missing newline Raw Output: examples/alerts/tests/latency_test.yaml:44: Missing newline
5 changes: 0 additions & 5 deletions make/alerts.mk
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,3 @@ alerts-tests: container-runtime-tool
-v $(LATENCY_SLO_RULES):/prometheus/slo-latency.yaml \
-v $(UNIT_TEST_DIR):/prometheus/tests --entrypoint=/bin/sh \
$(IMAGE) -c 'tail -n +7 slo-latency.yaml > latency-rules.yaml && tail -n +7 slo-availability.yaml > availability-rules.yaml && cd tests && promtool test rules *'





0 comments on commit 3cbe450

Please sign in to comment.