Skip to content

audit: Wave-34 re-score (post #280-#284) - #294

Merged
KooshaPari merged 1 commit into
mainfrom
feat/sl-w34-reaudit
Jul 17, 2026
Merged

audit: Wave-34 re-score (post #280-#284)#294
KooshaPari merged 1 commit into
mainfrom
feat/sl-w34-reaudit

Conversation

@KooshaPari

@KooshaPari KooshaPari commented Jul 17, 2026

Copy link
Copy Markdown
Owner

Summary

Test plan

  • Lane files + SCORECARD updated with file:line evidence
  • GAP_QA_MATRIX / TRACEABILITY / WBS synced

Conservative +7 from blocking sandbox-boundary (C04 L40), ADR 0005 edge
N/A (C11 L114), versioning policy (C11 L119), ErrorState non-color cues
(C09 L81.15), and soft es i18n (C01 L16). Held Wave-35 soft stubs.

Co-authored-by: Cursor <cursoragent@cursor.com>
@coderabbitai

coderabbitai Bot commented Jul 17, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@KooshaPari, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 46 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 1317008f-1eac-4cca-b73f-c73b38ab8f0a

📥 Commits

Reviewing files that changed from the base of the PR and between f1355a3 and 8eb96c2.

📒 Files selected for processing (8)
  • audit/.lane-c01/C01.md
  • audit/.lane-c04/C04.md
  • audit/.lane-c09/C09.md
  • audit/.lane-c11/C11.md
  • audit/SCORECARD.md
  • docs/ops/GAP_QA_MATRIX.md
  • docs/ops/TRACEABILITY.json
  • docs/ops/WBS.md
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/sl-w34-reaudit
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch feat/sl-w34-reaudit

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Risk: low. This PR updates audit scorecards and ops traceability docs only with no runtime code changes. Cursor Bugbot was not present on this PR; approving based on the low-risk documentation scope. No reviewers assigned.

Open in Web View Automation 

Sent by Cursor Approval Agent: Pull Request Approver

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the project's audit documentation, scorecard, traceability matrix, and gap QA matrix to reflect the progress made in Wave-34, raising the overall score to 95% (Grade A). The review feedback correctly identifies several inconsistencies where newly added test wrappers and locale files were omitted from the evidence arrays in TRACEABILITY.json and the acceptance criteria in GAP_QA_MATRIX.md. All review comments are valid and should be addressed to ensure complete traceability.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment on lines +847 to +851
"locales/en.json",
"locales/es.json",
"src/i18n.rs",
"docs/ops/i18n.md",
"scripts/i18n-check.ps1"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The test wrapper tests/i18n.rs is listed as core evidence in audit/.lane-c01/C01.md but is missing from the evidence array in TRACEABILITY.json. Adding it ensures complete traceability.

        "locales/en.json",
        "locales/es.json",
        "src/i18n.rs",
        "docs/ops/i18n.md",
        "scripts/i18n-check.ps1",
        "tests/i18n.rs"

Comment thread docs/ops/GAP_QA_MATRIX.md
| C00 | 28/30 · partial | Enforced p95 SoftLatencyCheck + soft Miri + soft loom + soft dhat alloc-profile landed; full loom/shuttle/blocking miri and jemalloc/production allocator remain | `audit/.lane-c00/C00.md`; `scripts/bench-gate.ps1`; `docs/ops/perf-baseline.json`; `.github/workflows/miri-smoke.yml`; `.github/workflows/loom-smoke.yml`; `docs/ops/alloc-profile.md`; `scripts/alloc-profile-check.ps1` | Add full permutation checkers and jemalloc/production allocator | 2026-07-14 |
| C01 | 27/30 · partial | Quality-gate SHA pin + clap completions landed; i18n remains | `audit/.lane-c01/C01.md`; `.github/workflows/qgate.yml`; `crates/sl-daemon/completions/`; `scripts/install-sl-daemon-completions.ps1` | Consider i18n only if multi-locale becomes a goal | 2026-07-14 |
| C02 | 28/30 · partial | Privacy hygiene SSOT + crypto inventory + Phase-0 KMS/at-rest deferred guidance landed; IdP/OAuth beyond shared key, in-tree KMS, and in-tree PII redaction remain | `docs/ops/privacy-hygiene.md`; `scripts/privacy-hygiene-check.ps1`; `docs/ops/crypto-inventory.md`; `crates/sl-daemon/src/resilience.rs`; `docs/ops/local-trust-boundary.md` | Add IdP/OAuth if remote multi-user deploy is needed; automated redaction if exports leave host | 2026-07-14 |
| C01 | 29/30 · partial | Quality-gate SHA pin + clap completions + soft `es` i18n catalog landed; Fluent/ICU multi-locale remains | `audit/.lane-c01/C01.md`; `locales/es.json`; `src/i18n.rs`; `docs/ops/i18n.md`; `scripts/i18n-check.ps1` | Wire Fluent/ICU and migrate viewer/CLI strings through catalogs | 2026-07-17 |

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The files locales/en.json and tests/i18n.rs are listed as core evidence in audit/.lane-c01/C01.md but are omitted from the acceptance test / evidence column in the QA matrix. Adding them keeps the matrix fully aligned with the audit lane.

Comment thread docs/ops/GAP_QA_MATRIX.md
| C02 | 29/30 · partial | Privacy hygiene SSOT + crypto inventory + Phase-0 KMS/at-rest deferred guidance + PII redaction stub landed; IdP/OAuth beyond shared key, in-tree KMS, and production PII redaction remain | `docs/ops/privacy-hygiene.md`; `scripts/privacy-hygiene-check.ps1`; `docs/ops/pii-redaction.md`; `docs/ops/crypto-inventory.md`; `crates/sl-daemon/src/resilience.rs`; `docs/ops/local-trust-boundary.md` | Add IdP/OAuth if remote multi-user deploy is needed; automated redaction if exports leave host | 2026-07-14 |
| C03 | 36/36 · done | Agent-readiness pillars at max after role-form FR stories and feedback budgets | `audit/.lane-c03/C03.md`; `docs/functional_requirements.md`; `docs/ops/feedback-budgets.md`; `scripts/feedback-budget-check.ps1` | Keep FR/journey/budget artifacts current | 2026-07-14 |
| C04 | 26/30 · partial | CVE feed GHSA+OSV+NVD SSOT + sandbox checklist + Renovate + branch-protection verify landed; maintainer 2FA and seccomp/no-net remain | `docs/ops/cve-feed-subscription.md`; `scripts/cve-feed-check.ps1`; `docs/ops/sandbox-boundary.md`; `scripts/sandbox-boundary-check.ps1`; `scripts/branch-protection-check.ps1`; `docs/ops/branch-protection.md`; `renovate.json` | Human records 2FA; add seccomp/no-net CI sandbox | 2026-07-14 |
| C04 | 27/30 · partial | CVE feed GHSA+OSV+NVD SSOT + blocking sandbox-boundary SelfCheck + Renovate + branch-protection verify landed; maintainer 2FA and hard rootless/no-net remain | `docs/ops/cve-feed-subscription.md`; `scripts/cve-feed-check.ps1`; `docs/ops/sandbox-boundary.md`; `scripts/sandbox-boundary-check.ps1`; `.github/workflows/security.yml`; `scripts/branch-protection-check.ps1`; `docs/ops/branch-protection.md`; `renovate.json` | Human records 2FA; add rootless/no-net hard CI | 2026-07-17 |

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The test wrappers tests/cve_feed.rs and tests/sandbox_boundary.rs are listed as core evidence in audit/.lane-c04/C04.md but are omitted from the acceptance test / evidence column in the QA matrix. Adding them keeps the matrix fully aligned with the audit lane.

Comment thread docs/ops/GAP_QA_MATRIX.md
| C08 | 27/30 · partial | Cross-language fixture parity SSOT + twenty-fixture corpus + compression eval + token-burn ledger landed; language adapters remain | `docs/ops/cross-language-parity.md`; `scripts/cross-language-parity-check.ps1`; `audit/.lane-c08/C08.md`; `docs/ops/token-burn.json`; `scripts/token-burn-check.ps1`; `tests/compression_eval.rs` | Grow production-scale families; ship cross-language adapters | 2026-07-14 |
| C09 | 43/45 · partial | Design-token single source + overlay Escape + expanded Cmd+K palette + live-daemon native attach landed; native WebView parity gaps remain | `docs/a11y/design-tokens.md`; `docs/a11y/overlay-escape.md`; `audit/.lane-c09/C09.md`; `crates/sl-viewer/src/tokens.rs`; `scripts/record-native-webview-smoke.ps1` | Deepen native parity; undo beyond confirm dialogs | 2026-07-14 |
| C08 | 29/30 · partial | Cross-language fixture parity SSOT + twenty-fixture corpus + compression eval + token-burn ledger + Python OKF adapter stub landed; Go/TS adapters remain | `docs/ops/cross-language-parity.md`; `scripts/cross-language-parity-check.ps1`; `audit/.lane-c08/C08.md`; `docs/ops/token-burn.json`; `scripts/token-burn-check.ps1`; `tests/compression_eval.rs` | Grow production-scale families; ship Go/TS OKF adapters | 2026-07-14 |
| C09 | 45/45 · done | Design-token single source + overlay Escape + expanded Cmd+K palette + ErrorState non-color cues landed; native WebView parity gaps remain soft | `docs/a11y/design-tokens.md`; `docs/a11y/overlay-escape.md`; `audit/.lane-c09/C09.md`; `crates/sl-viewer/src/async_states.rs`; `crates/sl-viewer/src/tokens.rs`; `scripts/record-native-webview-smoke.ps1` | Deepen native parity; undo beyond confirm dialogs | 2026-07-17 |

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The test wrapper tests/design_tokens.rs is listed as core evidence in audit/.lane-c09/C09.md but is omitted from the acceptance test / evidence column in the QA matrix. Adding it keeps the matrix fully aligned with the audit lane.

Comment thread docs/ops/GAP_QA_MATRIX.md
| C09 | 45/45 · done | Design-token single source + overlay Escape + expanded Cmd+K palette + ErrorState non-color cues landed; native WebView parity gaps remain soft | `docs/a11y/design-tokens.md`; `docs/a11y/overlay-escape.md`; `audit/.lane-c09/C09.md`; `crates/sl-viewer/src/async_states.rs`; `crates/sl-viewer/src/tokens.rs`; `scripts/record-native-webview-smoke.ps1` | Deepen native parity; undo beyond confirm dialogs | 2026-07-17 |
| C10 | 36/36 · done | Visual identity pillars at max after splash goldens | `audit/.lane-c10/C10.md`; `tests/visual/golden/s1-launch-splash.png`; `tests/visual/golden/s1-launch-splash-light.png` | Keep splash/theme goldens current | 2026-07-14 |
| C11 | 37/45 · partial | Brew/winget fill script + reverse-proxy + unsigned MSI/PKG + signing readiness checklist landed; live tap/winget publish and platform signing remain | `audit/.lane-c11/C11.md`; `docs/ops/signing-readiness.md`; `scripts/signing-readiness-check.ps1`; `docs/ops/brew-winget-publish.md`; `.github/workflows/release.yml` | Publish brew/winget; add credentials + signed production installer evidence | 2026-07-14 |
| C11 | 41/45 · partial | ADR 0005 edge N/A + versioning policy + brew/winget fill script + reverse-proxy + unsigned MSI/PKG + signing readiness checklist landed; live tap/winget publish and platform signing remain | `audit/.lane-c11/C11.md`; `docs/adr/0005-no-serverless-edge.md`; `docs/ops/versioning-policy.md`; `docs/ops/signing-readiness.md`; `scripts/signing-readiness-check.ps1`; `docs/ops/brew-winget-publish.md`; `.github/workflows/release.yml` | Publish brew/winget; add credentials + signed production installer evidence | 2026-07-17 |

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The test wrappers tests/edge_deploy_scope.rs and tests/versioning_policy.rs are listed as core evidence in audit/.lane-c11/C11.md but are omitted from the acceptance test / evidence column in the QA matrix. Adding them keeps the matrix fully aligned with the audit lane.

Comment on lines 1035 to 1041
"docs/adr/0003-platform-code-signing.md",
"docs/adr/0005-no-serverless-edge.md",
"docs/ops/versioning-policy.md",
"scripts/versioning-policy-check.ps1",
"scripts/edge-deploy-scope-check.ps1",
"docs/ops/signing-readiness.md",
"scripts/signing-readiness-check.ps1",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The test wrappers tests/edge_deploy_scope.rs and tests/versioning_policy.rs are listed as core evidence in audit/.lane-c11/C11.md but are missing from the evidence array in TRACEABILITY.json. Adding them ensures complete traceability.

        "docs/adr/0003-platform-code-signing.md",
        "docs/adr/0005-no-serverless-edge.md",
        "tests/edge_deploy_scope.rs",
        "docs/ops/versioning-policy.md",
        "tests/versioning_policy.rs",
        "scripts/versioning-policy-check.ps1",
        "scripts/edge-deploy-scope-check.ps1",
        "docs/ops/signing-readiness.md",
        "scripts/signing-readiness-check.ps1"

Comment on lines +1004 to +1005
"crates/sl-viewer/src/search_view.rs",
"crates/sl-viewer/src/async_states.rs"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The test wrapper tests/design_tokens.rs is listed as core evidence in audit/.lane-c09/C09.md but is missing from the evidence array in TRACEABILITY.json. Adding it ensures complete traceability.

        "crates/sl-viewer/src/search_view.rs",
        "crates/sl-viewer/src/async_states.rs",
        "tests/design_tokens.rs"

@KooshaPari KooshaPari changed the title audit: Wave-34 re-score after #280-#284 audit: Wave-34 re-score (post #280-#284) Jul 17, 2026
@KooshaPari
KooshaPari merged commit 41da283 into main Jul 17, 2026
55 of 57 checks passed
KooshaPari added a commit that referenced this pull request Jul 17, 2026
Conservative +7 from blocking sandbox-boundary (C04 L40), ADR 0005 edge
N/A (C11 L114), versioning policy (C11 L119), ErrorState non-color cues
(C09 L81.15), and soft es i18n (C01 L16). Held Wave-35 soft stubs.

Co-authored-by: Cursor <cursoragent@cursor.com>
@KooshaPari
KooshaPari deleted the feat/sl-w34-reaudit branch August 12, 2026 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant