feat(viewer): ErrorState non-color cues (C09 L81.15) - #283
Conversation
Pair danger color with glyph, alert role, and aria-invalid. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
|
Warning Review limit reached
Next review available in: 55 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (3)
✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![kilo-code-bot[bot]](https://avatars.githubusercontent.com/in/2193792?s=60&v=4){kind=small}
| class: "sl-error-state", | ||
| role: "alert", | ||
| "aria-live": "assertive", | ||
| "aria-invalid": "true", |
There was a problem hiding this comment.
WARNING: aria-invalid="true" on a div with role="alert" is invalid ARIA
aria-invalid is only valid on form controls. The role="alert" already provides the necessary accessibility announcement for error messages. This attribute should be removed or applied to an actual form input element.
Reply with @kilocode-bot fix it to have Kilo Code address this issue.
|
|
||
| Do **not** use `--lc-orange` as the sole error signal (orange = live). Do **not** use cobalt for failure text. | ||
|
|
||
| **Non-color cues (L81.15):** every recoverable error panel (`ErrorState`) must pair color with at least one of: a warning glyph (`aria-hidden`), a distinct left border, `role="alert"`, and/or `aria-invalid="true"`. Color alone is never sufficient. |
There was a problem hiding this comment.
SUGGESTION: Clarify that aria-invalid must be on a form control
The spec lists aria-invalid="true" as an acceptable non-color cue without specifying it must be on a form control element. This could lead to future implementations that place it on non-form elements (as seen in this PR's ErrorState div), which is invalid ARIA.
Reply with @kilocode-bot fix it to have Kilo Code address this issue.
Code Review SummaryStatus: 2 Issues Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
SUGGESTION
Files Reviewed (3 files)
Fix these issues in Kilo Cloud Reviewed by step-3.7-flash · Input: 133.3K · Output: 10.9K · Cached: 244.9K |
1 participant
Summary
ErrorStateadds warning glyph +aria-invalidnon-color cues (C09 L81.15).Test plan