-
Notifications
You must be signed in to change notification settings - Fork 0
feat(viewer): ErrorState non-color cues (C09 L81.15) #283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
74742d0
5ed5e64
85d6239
201b3ed
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -168,6 +168,8 @@ Errors are recoverable by default; show message + path forward. | |
|
|
||
| Do **not** use `--lc-orange` as the sole error signal (orange = live). Do **not** use cobalt for failure text. | ||
|
|
||
| **Non-color cues (L81.15):** every recoverable error panel (`ErrorState`) must pair color with at least one of: a warning glyph (`aria-hidden`), a distinct left border, `role="alert"`, and/or `aria-invalid="true"`. Color alone is never sufficient. | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. SUGGESTION: Clarify that The spec lists Reply with |
||
|
|
||
| ### Surfaces | ||
|
|
||
| | Surface | Behavior | | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WARNING:
aria-invalid="true"on a div withrole="alert"is invalid ARIAaria-invalidis only valid on form controls. Therole="alert"already provides the necessary accessibility announcement for error messages. This attribute should be removed or applied to an actual form input element.Reply with
@kilocode-bot fix itto have Kilo Code address this issue.