Merged
Conversation
borngraced
previously approved these changes
Dec 27, 2024
onur-ozkan
suggested changes
Dec 27, 2024
There was a problem hiding this comment.
I would create separate pipeline for checking Cargo.lock
.github/workflows/fmt-and-lint.yml
Outdated
Comment on lines
+32
to
+33
| - name: Backup Cargo.lock | ||
| run: cp Cargo.lock Cargo.lock.bak |
There was a problem hiding this comment.
We could simply run cargo update -w --locked which will fail if Cargo.lock isn't up-to-date.
Author
There was a problem hiding this comment.
Cool, does the job!
https://github.com/KomodoPlatform/komodo-defi-framework/actions/runs/12526268691/job/34938647572
Adding web-time v1.1.0
error: the lock file /home/runner/work/komodo-defi-framework/komodo-defi-framework/Cargo.lock needs to be updated but --locked was passed to prevent this
commit 4d83f94
laruh
force-pushed
the
ci-check-cargo-lock
branch
from
3fb42e3 to
4d83f94
Compare
onur-ozkan
reviewed
Dec 30, 2024
Comment on lines
+10
to
+24
| name: Validate Cargo.lock Consistency | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Checkout repository | ||
| uses: actions/checkout@v3 | ||
|
|
||
| - name: Install Rust toolchain | ||
| run: | | ||
| rustup toolchain install nightly-2023-06-01 --no-self-update --profile=minimal | ||
| rustup default nightly-2023-06-01 | ||
|
|
||
| - name: Validate Cargo.lock | ||
| run: | | ||
| echo "Checking if Cargo.lock is up-to-date..." | ||
| cargo update -w --locked |
There was a problem hiding this comment.
to simplify:
Suggested change
| name: Validate Cargo.lock Consistency | |
| runs-on: ubuntu-latest | |
| steps: | |
| - name: Checkout repository | |
| uses: actions/checkout@v3 | |
| - name: Install Rust toolchain | |
| run: | | |
| rustup toolchain install nightly-2023-06-01 --no-self-update --profile=minimal | |
| rustup default nightly-2023-06-01 | |
| - name: Validate Cargo.lock | |
| run: | | |
| echo "Checking if Cargo.lock is up-to-date..." | |
| cargo update -w --locked | |
| name: Checking Cargo.lock file | |
| runs-on: ubuntu-latest | |
| steps: | |
| uses: actions/checkout@v3 | |
| - name: Validate Cargo.lock | |
| run: cargo update -w --locked |
Author
There was a problem hiding this comment.
Do we really need to skip rustup toolchain install step?
There was a problem hiding this comment.
We could as cargo update will trigger that already.
onur-ozkan
approved these changes
Jan 7, 2025
dimxy
pushed a commit
to dimxy/komodo-defi-framework
that referenced
this pull request
Jan 17, 2025
* dev: (35 commits) fix(crypto): allow non bip39 mnemonics storage (GLEECBTC#2312) fix(legacy_swap): check for existing maker/taker payment before timeout (GLEECBTC#2283) feat(tendermint): validators RPC (GLEECBTC#2310) chore(CI): validate Cargo lock file (GLEECBTC#2309) test(P2P): add test for peer time sync validation (GLEECBTC#2304) fix mm2_p2p dev build (GLEECBTC#2311) update Cargo.lock (GLEECBTC#2308) chore(CI): unlock wasm-pack version (GLEECBTC#2307) add `wasm` feature on WASM for timed-map (GLEECBTC#2306) replace broken rpc link (GLEECBTC#2305) chore(eth-websocket): remove some unnecessary wrappers (GLEECBTC#2291) improvement(CI): switch to proper rust caching (GLEECBTC#2303) fix(wasm): add test-ext-api feature to mm2_main and mm2_bin_lib tomls (GLEECBTC#2295) chore(ci): Update docker build for wasm (GLEECBTC#2294) chore(p2p): follow-up nits (GLEECBTC#2302) feat(p2p): ensure time synchronization in the network (GLEECBTC#2255) bump libp2p (GLEECBTC#2296) chore(adex-cli): use "Komodo DeFi Framework" name in adex_cli (GLEECBTC#2290) chore(ctx): replace gstuff constructible with oncelock (GLEECBTC#2267) don't rely on core (GLEECBTC#2289) ...
shamardy
pushed a commit
that referenced
this pull request
Jan 28, 2025
* Validate Cargo.lock * Revert "Validate Cargo.lock" and add validate-cargo-lock.yml * review: run only `cargo update` and simplify yml
shamardy
pushed a commit
that referenced
this pull request
Jan 30, 2025
* Validate Cargo.lock * Revert "Validate Cargo.lock" and add validate-cargo-lock.yml * review: run only `cargo update` and simplify yml
shamardy
pushed a commit
that referenced
this pull request
Jan 30, 2025
* Validate Cargo.lock * Revert "Validate Cargo.lock" and add validate-cargo-lock.yml * review: run only `cargo update` and simplify yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.