improvement(CI): switch to proper rust caching#2303
Merged
onur-ozkan merged 5 commits intodevfrom Dec 26, 2024
Merged
Conversation
Signed-off-by: onur-ozkan <work@onurozkan.dev>
Signed-off-by: onur-ozkan <work@onurozkan.dev>
Signed-off-by: onur-ozkan <work@onurozkan.dev>
onur-ozkan
force-pushed
the
improve-caching
branch
from
2de4e18 to
566eddf
Compare
Signed-off-by: onur-ozkan <work@onurozkan.dev>
Signed-off-by: onur-ozkan <work@onurozkan.dev>
|
Can you try pushing multiple commits at different intervals and see if it will trigger cache issue again.. cc @onur-ozkan |
Author
|
I think it will never be enough to know if this fixes the problem entirely. There is one way of finding it out, which is merging it to dev. Consider this as a general improvement on caching, as you can see build times are reduced by couple minutes. |
borngraced
approved these changes
Dec 25, 2024
dimxy
reviewed
Dec 26, 2024
dimxy
approved these changes
Dec 26, 2024
dimxy
pushed a commit
to dimxy/komodo-defi-framework
that referenced
this pull request
Jan 17, 2025
* dev: (35 commits) fix(crypto): allow non bip39 mnemonics storage (GLEECBTC#2312) fix(legacy_swap): check for existing maker/taker payment before timeout (GLEECBTC#2283) feat(tendermint): validators RPC (GLEECBTC#2310) chore(CI): validate Cargo lock file (GLEECBTC#2309) test(P2P): add test for peer time sync validation (GLEECBTC#2304) fix mm2_p2p dev build (GLEECBTC#2311) update Cargo.lock (GLEECBTC#2308) chore(CI): unlock wasm-pack version (GLEECBTC#2307) add `wasm` feature on WASM for timed-map (GLEECBTC#2306) replace broken rpc link (GLEECBTC#2305) chore(eth-websocket): remove some unnecessary wrappers (GLEECBTC#2291) improvement(CI): switch to proper rust caching (GLEECBTC#2303) fix(wasm): add test-ext-api feature to mm2_main and mm2_bin_lib tomls (GLEECBTC#2295) chore(ci): Update docker build for wasm (GLEECBTC#2294) chore(p2p): follow-up nits (GLEECBTC#2302) feat(p2p): ensure time synchronization in the network (GLEECBTC#2255) bump libp2p (GLEECBTC#2296) chore(adex-cli): use "Komodo DeFi Framework" name in adex_cli (GLEECBTC#2290) chore(ctx): replace gstuff constructible with oncelock (GLEECBTC#2267) don't rely on core (GLEECBTC#2289) ...
shamardy
pushed a commit
that referenced
this pull request
Jan 28, 2025
* switch to proper rust caching Signed-off-by: onur-ozkan <work@onurozkan.dev> * fix linting Signed-off-by: onur-ozkan <work@onurozkan.dev> * rename cargo-cache to build-cache Signed-off-by: onur-ozkan <work@onurozkan.dev> * try caching Signed-off-by: onur-ozkan <work@onurozkan.dev> * switch to rust-cache Signed-off-by: onur-ozkan <work@onurozkan.dev> --------- Signed-off-by: onur-ozkan <work@onurozkan.dev>
shamardy
pushed a commit
that referenced
this pull request
Jan 30, 2025
* switch to proper rust caching Signed-off-by: onur-ozkan <work@onurozkan.dev> * fix linting Signed-off-by: onur-ozkan <work@onurozkan.dev> * rename cargo-cache to build-cache Signed-off-by: onur-ozkan <work@onurozkan.dev> * try caching Signed-off-by: onur-ozkan <work@onurozkan.dev> * switch to rust-cache Signed-off-by: onur-ozkan <work@onurozkan.dev> --------- Signed-off-by: onur-ozkan <work@onurozkan.dev>
shamardy
pushed a commit
that referenced
this pull request
Jan 30, 2025
* switch to proper rust caching Signed-off-by: onur-ozkan <work@onurozkan.dev> * fix linting Signed-off-by: onur-ozkan <work@onurozkan.dev> * rename cargo-cache to build-cache Signed-off-by: onur-ozkan <work@onurozkan.dev> * try caching Signed-off-by: onur-ozkan <work@onurozkan.dev> * switch to rust-cache Signed-off-by: onur-ozkan <work@onurozkan.dev> --------- Signed-off-by: onur-ozkan <work@onurozkan.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
self-explanatory (see commit by commit if it helps)