chore(ci): Update docker build for wasm#2294
Merged
onur-ozkan merged 2 commits intodevfrom Dec 24, 2024
Merged
Conversation
smk762
changed the title
onur-ozkan
force-pushed
the
container-update-protoc
branch
3 times, most recently
from
3571542 to
c13fa4c
Compare
Signed-off-by: onur-ozkan <work@onurozkan.dev>
onur-ozkan
force-pushed
the
container-update-protoc
branch
from
c13fa4c to
fff54c1
Compare
onur-ozkan
approved these changes
Dec 23, 2024
onur-ozkan
left a comment
onur-ozkan
left a comment
There was a problem hiding this comment.
LGTM
I locked the wasm-pack version for security concerns. That part should be reviewed by someone else.
borngraced
suggested changes
Dec 23, 2024
|
|
||
| - name: Install wasm-pack | ||
| run: curl https://rustwasm.github.io/wasm-pack/installer/init.sh -sSf | bash -s -- -y | ||
| run: CARGO_HOME=/root/.cargo cargo install wasm-pack --version 0.10.3 |
There was a problem hiding this comment.
why did you pick this version? I see problems with compilation on windows with this specific version.
wasm-bindgen/wasm-pack#1157
There was a problem hiding this comment.
It's the latest version that is compatible with our toolchain. We shouldn't need to worry about Windows errors as we don't build for Windows.
borngraced
approved these changes
Dec 23, 2024
dimxy
pushed a commit
to dimxy/komodo-defi-framework
that referenced
this pull request
Jan 17, 2025
* dev: (35 commits) fix(crypto): allow non bip39 mnemonics storage (GLEECBTC#2312) fix(legacy_swap): check for existing maker/taker payment before timeout (GLEECBTC#2283) feat(tendermint): validators RPC (GLEECBTC#2310) chore(CI): validate Cargo lock file (GLEECBTC#2309) test(P2P): add test for peer time sync validation (GLEECBTC#2304) fix mm2_p2p dev build (GLEECBTC#2311) update Cargo.lock (GLEECBTC#2308) chore(CI): unlock wasm-pack version (GLEECBTC#2307) add `wasm` feature on WASM for timed-map (GLEECBTC#2306) replace broken rpc link (GLEECBTC#2305) chore(eth-websocket): remove some unnecessary wrappers (GLEECBTC#2291) improvement(CI): switch to proper rust caching (GLEECBTC#2303) fix(wasm): add test-ext-api feature to mm2_main and mm2_bin_lib tomls (GLEECBTC#2295) chore(ci): Update docker build for wasm (GLEECBTC#2294) chore(p2p): follow-up nits (GLEECBTC#2302) feat(p2p): ensure time synchronization in the network (GLEECBTC#2255) bump libp2p (GLEECBTC#2296) chore(adex-cli): use "Komodo DeFi Framework" name in adex_cli (GLEECBTC#2290) chore(ctx): replace gstuff constructible with oncelock (GLEECBTC#2267) don't rely on core (GLEECBTC#2289) ...
shamardy
pushed a commit
that referenced
this pull request
Jan 28, 2025
* update wasm build for docker * lock wasm-pack version on build runners Signed-off-by: onur-ozkan <work@onurozkan.dev> --------- Signed-off-by: onur-ozkan <work@onurozkan.dev> Co-authored-by: onur-ozkan <work@onurozkan.dev>
shamardy
pushed a commit
that referenced
this pull request
Jan 30, 2025
* update wasm build for docker * lock wasm-pack version on build runners Signed-off-by: onur-ozkan <work@onurozkan.dev> --------- Signed-off-by: onur-ozkan <work@onurozkan.dev> Co-authored-by: onur-ozkan <work@onurozkan.dev>
shamardy
pushed a commit
that referenced
this pull request
Jan 30, 2025
* update wasm build for docker * lock wasm-pack version on build runners Signed-off-by: onur-ozkan <work@onurozkan.dev> --------- Signed-off-by: onur-ozkan <work@onurozkan.dev> Co-authored-by: onur-ozkan <work@onurozkan.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was getting errors building current dev branch in both container and local system:
Referring to the GHA workflow deps, I noticed a different protoc version so updated it in the Dockerfile.
I also added rustwasm install from script step from GHA to avoid the version error above.
Additionally the WASM_BUILD doc was updated to include instructions for building via docker.