feat(tendermint): validators RPC by onur-ozkan · Pull Request #2310 · GLEECBTC/komodo-defi-framework

onur-ozkan · 2025-01-02T09:03:49Z

This is the initial implementation related to Tendermint staking feature on KDF. Remaining parts will be added gradually one by one similar to the validators RPC in this PR.

e.g., RPC payload structure:

https://github.com/KomodoPlatform/komodo-defi-framework/blob/4c63f6efbef97cf5a88a9b58ffb8d49041255de3/mm2src/mm2_test_helpers/src/for_tests.rs#L3102-L3112

filter_by_status can be set to one of All, Bonded and Unbonded. Default is All.

Explanation of Bonded and Unbonded statuses:

https://github.com/KomodoPlatform/komodo-defi-framework/blob/43dbf48d4ae09d1774b2df5dc195a236920b3e64/mm2src/coins/rpc_command/tendermint/staking.rs#L12-L18

Signed-off-by: onur-ozkan <work@onurozkan.dev>

mm2src/coins/rpc_command/tendermint/staking.rs

borngraced

great work!

Signed-off-by: onur-ozkan <work@onurozkan.dev>

mariocynicys

thank YOU :)

mm2src/mm2_test_helpers/src/for_tests.rs

mm2src/mm2_main/tests/docker_tests/tendermint_tests.rs

mm2src/coins/tendermint/tendermint_coin.rs

mm2src/coins/rpc_command/tendermint/staking.rs

Signed-off-by: onur-ozkan <work@onurozkan.dev>

mariocynicys

Thanks
LGTM!

* dev: feat(tendermint): validators RPC (#2310) chore(CI): validate Cargo lock file (#2309) test(P2P): add test for peer time sync validation (#2304)

* dev: (35 commits) fix(crypto): allow non bip39 mnemonics storage (GLEECBTC#2312) fix(legacy_swap): check for existing maker/taker payment before timeout (GLEECBTC#2283) feat(tendermint): validators RPC (GLEECBTC#2310) chore(CI): validate Cargo lock file (GLEECBTC#2309) test(P2P): add test for peer time sync validation (GLEECBTC#2304) fix mm2_p2p dev build (GLEECBTC#2311) update Cargo.lock (GLEECBTC#2308) chore(CI): unlock wasm-pack version (GLEECBTC#2307) add `wasm` feature on WASM for timed-map (GLEECBTC#2306) replace broken rpc link (GLEECBTC#2305) chore(eth-websocket): remove some unnecessary wrappers (GLEECBTC#2291) improvement(CI): switch to proper rust caching (GLEECBTC#2303) fix(wasm): add test-ext-api feature to mm2_main and mm2_bin_lib tomls (GLEECBTC#2295) chore(ci): Update docker build for wasm (GLEECBTC#2294) chore(p2p): follow-up nits (GLEECBTC#2302) feat(p2p): ensure time synchronization in the network (GLEECBTC#2255) bump libp2p (GLEECBTC#2296) chore(adex-cli): use "Komodo DeFi Framework" name in adex_cli (GLEECBTC#2290) chore(ctx): replace gstuff constructible with oncelock (GLEECBTC#2267) don't rely on core (GLEECBTC#2289) ...

* save dev state Signed-off-by: onur-ozkan <work@onurozkan.dev> * save dev state Signed-off-by: onur-ozkan <work@onurozkan.dev> * make proto types serializable for RPC endpoint Signed-off-by: onur-ozkan <work@onurozkan.dev> * remove dummy test Signed-off-by: onur-ozkan <work@onurozkan.dev> * add RPC error type Signed-off-by: onur-ozkan <work@onurozkan.dev> * add TODO Signed-off-by: onur-ozkan <work@onurozkan.dev> * fix status filtering Signed-off-by: onur-ozkan <work@onurozkan.dev> * fix clippy warn Signed-off-by: onur-ozkan <work@onurozkan.dev> * resolve `todo!()`s Signed-off-by: onur-ozkan <work@onurozkan.dev> * remove inline attribute Signed-off-by: onur-ozkan <work@onurozkan.dev> * improve `validators_rpc` Signed-off-by: onur-ozkan <work@onurozkan.dev> * add coverage for tendermint_validators RPC Signed-off-by: onur-ozkan <work@onurozkan.dev> * apply nit changes Signed-off-by: onur-ozkan <work@onurozkan.dev> * document `ValidatorStatus` Signed-off-by: onur-ozkan <work@onurozkan.dev> * use proper error variant on coin filtering Signed-off-by: onur-ozkan <work@onurozkan.dev> * apply nits Signed-off-by: onur-ozkan <work@onurozkan.dev> --------- Signed-off-by: onur-ozkan <work@onurozkan.dev>

onur-ozkan added 7 commits December 31, 2024 14:16

save dev state

9fc3319

Signed-off-by: onur-ozkan <work@onurozkan.dev>

save dev state

a6ebe1c

Signed-off-by: onur-ozkan <work@onurozkan.dev>

make proto types serializable for RPC endpoint

9198049

Signed-off-by: onur-ozkan <work@onurozkan.dev>

remove dummy test

b48c1ba

Signed-off-by: onur-ozkan <work@onurozkan.dev>

add RPC error type

2470594

Signed-off-by: onur-ozkan <work@onurozkan.dev>

add TODO

c4df52a

Signed-off-by: onur-ozkan <work@onurozkan.dev>

fix status filtering

95d008b

Signed-off-by: onur-ozkan <work@onurozkan.dev>

onur-ozkan added status: in progress feature: protocol feature: RPC labels Jan 2, 2025

onur-ozkan added 5 commits January 2, 2025 12:06

fix clippy warn

61b1654

Signed-off-by: onur-ozkan <work@onurozkan.dev>

resolve todo!()s

8d59f4d

Signed-off-by: onur-ozkan <work@onurozkan.dev>

remove inline attribute

05eb07e

Signed-off-by: onur-ozkan <work@onurozkan.dev>

improve validators_rpc

838bee4

Signed-off-by: onur-ozkan <work@onurozkan.dev>

add coverage for tendermint_validators RPC

ee20b9a

Signed-off-by: onur-ozkan <work@onurozkan.dev>

onur-ozkan force-pushed the validator-rpcs branch from 9d0e6c8 to ee20b9a Compare January 2, 2025 11:26

apply nit changes

4c63f6e

Signed-off-by: onur-ozkan <work@onurozkan.dev>

onur-ozkan added status: pending review and removed status: in progress labels Jan 6, 2025

onur-ozkan marked this pull request as ready for review January 6, 2025 06:09

document ValidatorStatus

43dbf48

Signed-off-by: onur-ozkan <work@onurozkan.dev>

borngraced reviewed Jan 6, 2025

View reviewed changes

mm2src/coins/rpc_command/tendermint/staking.rs Outdated Show resolved Hide resolved

borngraced previously approved these changes Jan 6, 2025

View reviewed changes

use proper error variant on coin filtering

db5cff6

Signed-off-by: onur-ozkan <work@onurozkan.dev>

onur-ozkan dismissed borngraced’s stale review via db5cff6 January 6, 2025 12:27

mariocynicys reviewed Jan 6, 2025

View reviewed changes

apply nits

96306cc

Signed-off-by: onur-ozkan <work@onurozkan.dev>

onur-ozkan force-pushed the validator-rpcs branch from 9006269 to 96306cc Compare January 7, 2025 08:09

mariocynicys approved these changes Jan 8, 2025

View reviewed changes

onur-ozkan merged commit 1908a2e into dev Jan 8, 2025

onur-ozkan deleted the validator-rpcs branch January 8, 2025 08:12

dimxy pushed a commit that referenced this pull request Jan 8, 2025

Merge branch 'dev' into fix-utxo-tx-fee-for-change

455403c

* dev: feat(tendermint): validators RPC (#2310) chore(CI): validate Cargo lock file (#2309) test(P2P): add test for peer time sync validation (#2304)

shamardy mentioned this pull request Apr 16, 2025

chore(release): v2.4.0-beta #2345

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(tendermint): validators RPC#2310

feat(tendermint): validators RPC#2310
onur-ozkan merged 16 commits intodevfrom
validator-rpcs

onur-ozkan commented Jan 2, 2025 •

edited

Loading

Uh oh!

Uh oh!

borngraced left a comment

Uh oh!

mariocynicys left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mariocynicys left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

onur-ozkan commented Jan 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

borngraced left a comment

Choose a reason for hiding this comment

Uh oh!

mariocynicys left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mariocynicys left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

onur-ozkan commented Jan 2, 2025 •

edited

Loading