Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Travis CI with GitHub Actions #112

Merged
merged 1 commit into from
Jun 22, 2021
Merged

Conversation

tnir
Copy link
Contributor

@tnir tnir commented Jun 19, 2021

We do not see any new builds on Travis CI (.org) https://travis-ci.org/github/KnapsackPro/knapsack/builds (and the project is not found on .com https://travis-ci.com/github/KnapsackPro/knapsack).

Blocked by #114

Changes

  • The base OS image was upgraded from Ubuntu 16.04 LTS to 20.04 LTS.

Announcement from Travis

https://blog.travis-ci.com/2020-11-02-travis-ci-new-billing
https://blog.travis-ci.com/oss-announcement

Counterpart PRs

Signed-off-by: Takuya Noguchi [email protected]

@tnir
Copy link
Contributor Author

tnir commented Jun 19, 2021

This PR is only for push or PR for master, https://github.com/tnir/knapsack/runs/2865274937 shows the results expected with this PR to you. Note that job with Ruby 2.1 fails.

Ruby 2.1 is preserved in this PR since it has been preserved even in #110 and/or on d4f2c80.

.github/workflows/ruby.yml Outdated Show resolved Hide resolved
@ArturT
Copy link
Member

ArturT commented Jun 21, 2021

Could you fix the conflict in .travis.yml? It was changed in your PR that I've merged. You could simply remove this file again to resolve the conflict.

I'm wondering what to do with failing build in Ruby 2.1.

On one hand Ruby 2.1 support has ended but on the other hand, I don't want to make the hard requirement of >= Ruby 2.2 to force users to use newer Ruby if they have legacy projects.

Regarding the error:

/opt/hostedtoolcache/Ruby/2.1.9/x64/lib/ruby/2.1.0/minitest/unit.rb:26:in `const_missing': uninitialized constant MiniTest::Test (NameError)
	from /home/runner/work/knapsack/knapsack/lib/knapsack/adapters/minitest_adapter.rb:24:in `bind_time_tracker'

Maybe we need a similar condition for Ruby 2.1 as here for Ruby 1.9.3.

Ruby 2.1.10 seems to be the latest version available for 2.1.x.

Maybe something like that?

if RUBY_VERSION == "2.1.10"
  unless defined? MiniTest::Test
    MiniTest::Test = Minitest::Test
  end
end

@tnir tnir force-pushed the actions branch 3 times, most recently from 228a824 to 8bac66d Compare June 22, 2021 05:06
@tnir
Copy link
Contributor Author

tnir commented Jun 22, 2021

Could you fix the conflict in .travis.yml? It was changed in your PR that I've merged. You could simply remove this file again to resolve the conflict.

Yes, I did it.

I'm wondering what to do with failing build in Ruby 2.1.

The tweak for minitest 4 (which had been bundled with Ruby 1.9 through 2.1) introduced in #26 does bad. We expected minitest 5 in #16, but we could not have been using minitest 5.x on CI (with Ruby 2.1 or earlier). We can merge #114 first.

@ArturT ArturT merged commit fc771e3 into KnapsackPro:master Jun 22, 2021
@ArturT
Copy link
Member

ArturT commented Jun 22, 2021

I've merged #114 and I merged this PR as well but CI build for Ruby 2.1 still was failing.

I decided to drop support for Ruby 2.1 here.

@ArturT
Copy link
Member

ArturT commented Jun 22, 2021

I've released knapsack 3.0.0.

Thanks @tnir for your help. :)

@tnir tnir deleted the actions branch June 22, 2021 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants