-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace Travis CI with GitHub Actions #112
Conversation
This PR is only for Ruby 2.1 is preserved in this PR since it has been preserved even in #110 and/or on d4f2c80. |
Could you fix the conflict in I'm wondering what to do with failing build in Ruby 2.1. On one hand Ruby 2.1 support has ended but on the other hand, I don't want to make the hard requirement of >= Ruby 2.2 to force users to use newer Ruby if they have legacy projects. Regarding the error:
Maybe we need a similar condition for Ruby 2.1 as here for Ruby 1.9.3. Ruby 2.1.10 seems to be the latest version available for 2.1.x. Maybe something like that? if RUBY_VERSION == "2.1.10"
unless defined? MiniTest::Test
MiniTest::Test = Minitest::Test
end
end |
228a824
to
8bac66d
Compare
Yes, I did it.
The tweak for minitest 4 (which had been bundled with Ruby 1.9 through 2.1) introduced in #26 does bad. We expected minitest 5 in #16, but we could not have been using minitest 5.x on CI (with Ruby 2.1 or earlier). We can merge #114 first. |
I've merged #114 and I merged this PR as well but CI build for Ruby 2.1 still was failing. I decided to drop support for Ruby 2.1 here. |
I've released knapsack 3.0.0. Thanks @tnir for your help. :) |
We do not see any new builds on Travis CI (.org) https://travis-ci.org/github/KnapsackPro/knapsack/builds (and the project is not found on .com https://travis-ci.com/github/KnapsackPro/knapsack).
Blocked by #114
Changes
Announcement from Travis
https://blog.travis-ci.com/2020-11-02-travis-ci-new-billing
https://blog.travis-ci.com/oss-announcement
Counterpart PRs
Signed-off-by: Takuya Noguchi [email protected]