Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require minimum Ruby 2.2 version #115

Merged
merged 2 commits into from
Jun 22, 2021
Merged

Require minimum Ruby 2.2 version #115

merged 2 commits into from
Jun 22, 2021

Conversation

ArturT
Copy link
Member

@ArturT ArturT commented Jun 22, 2021

Related to #112

minitest 4 is bundled with Ruby 2.1

Forcing to use minitest 5 with Ruby 2.1 still causes CI build to fail https://github.com/KnapsackPro/knapsack/runs/2883581100?check_suite_focus=true

KNAPSACK_TEST_FILE_PATTERN="test_examples/**{,/*/**}/*_test.rb" bundle exec rake "knapsack:minitest[--verbose]"

...

/opt/hostedtoolcache/Ruby/2.1.9/x64/lib/ruby/2.1.0/minitest/unit.rb:26:in `const_missing': uninitialized constant MiniTest::Test (NameError)
	from /home/runner/work/knapsack/knapsack/lib/knapsack/adapters/minitest_adapter.rb:24:in `bind_time_tracker'

Related

Support for Minitest 4 was removed in #114

solution

Let's use Ruby 2.2 as the minimum required version.

@ArturT ArturT merged commit 67efabd into master Jun 22, 2021
@ArturT ArturT deleted the min-ruby-version branch June 22, 2021 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant