Reverts #77 with the minimal ruby version 2.1+ #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
de491d6 dropped 1.9 support in 2015-07. Revert "Merge pull request KnapsackPro#77 from nicolasleger/ruby-1-9" This reverts commit 754f0f5, reversing changes made to 96a0eeb. Signed-off-by: Takuya Noguchi <[email protected]>
|
Thank you @tnir for this clean up. |
|
I've released the knapsack 2.0.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #77 with dumping the minimal ruby version from 1.9.3 to 2.1+.
de491d6 dropped 1.9 support from CI in 2015-07 (6 years ago).
Revert "Merge pull request #77 from nicolasleger/ruby-1-9"
This reverts commit 754f0f5, reversing
changes made to 96a0eeb.
Signed-off-by: Takuya Noguchi [email protected]
Why Ruby 2.1+?
https://github.com/KnapsackPro/docs.knapsackpro.com/blob/5fe2c9460fe36939d145ff07e9ac8b21848d7399/docs/ruby/knapsack/readme.md#requirements says: